Skip to content

Promote development for review application changes#479

Merged
steveoh merged 26 commits intomainfrom
dev
Jul 16, 2025
Merged

Promote development for review application changes#479
steveoh merged 26 commits intomainfrom
dev

Conversation

@steveoh
Copy link
Copy Markdown
Contributor

@steveoh steveoh commented Jul 15, 2025

updates the submission status component and blocks cancellation after review

@steveoh steveoh requested a review from Copilot July 15, 2025 00:23

This comment was marked as outdated.

This comment was marked as outdated.

steveoh and others added 2 commits July 14, 2025 18:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@steveoh steveoh requested a review from stdavis July 15, 2025 00:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhance submission status handling and enforce review-based cancellation rules across UI and backend.

  • Block submission cancellation in the UI and functions once a submission is reviewed or published.
  • Extend getStatus and its tests to surface new sheetPublished and dataPublished states.
  • Refactor submissions UI into its own component with shared utilities, and standardize structured logging in Cloud Functions.

Reviewed Changes

Copilot reviewed 48 out of 70 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vite.config.js Update Vitest config to use environment and set emulator host.
storage.rules Grant read access only to the current user’s stored files.
src/components/pageElements/utils.js Introduce dateFormatter and sortFunction for submission lists.
src/components/pageElements/Submissions.jsx Extract Submissions UI, disable Cancel button after review.
functions/shared/index.js Extend getStatus to handle new publication states.
functions/shared/index.test.js Update unit tests for updated status labels and fields.
functions/https/postCancelCorner.js Prevent cancellation of reviewed/published submissions; logging fix.
firestore.rules Allow create operations in stats collection for review app.
Comments suppressed due to low confidence (9)

src/components/pageElements/utils.js:10

  • The newly introduced sortFunction is not covered by unit tests. Consider adding tests that validate sorting for each supported sortOrder to prevent regressions.
export const sortFunction = (sortOrder, transform) => {

src/components/pageElements/mapElements/Township.jsx:3

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/pageElements/mapElements/MyLocation.jsx:3

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/pageElements/Map.jsx:20

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/formElements/Switch.jsx:2

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/formElements/Select.jsx:3

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/formElements/Inputs.jsx:1

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/formElements/FileUpload.jsx:2

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

src/components/formElements/Buttons.jsx:3

  • The clsx package exports a default function rather than a named export. Change this to import clsx from 'clsx'; to avoid runtime import errors.
import { clsx } from 'clsx';

steveoh and others added 2 commits July 14, 2025 19:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@steveoh steveoh merged commit d635e4d into main Jul 16, 2025
10 checks passed
@steveoh steveoh deleted the dev branch July 16, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants