Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the file upload UI for shapefiles by migrating from a native HTML file input to the UDS (Utah Design System) FileInput component and adds a clear button for the area of interest. The changes improve consistency with the design system and enhance user experience with better file handling feedback and the ability to clear drawn polygons.
Key changes:
- Refactored
useShapefileUploadhook to acceptFileListdirectly instead of React change events - Integrated UDS
FileInputcomponent with proper error handling and loading states - Added "Clear Area of Interest" button with extracted clear functionality
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/hooks/useShapefileUpload.ts |
Modified hook signature to accept FileList instead of React.ChangeEvent, added onClear callback, removed manual input reset logic, and reordered error clearing for better UX |
src/AppSearch.tsx |
Replaced native file input with UDS FileInput component, extracted clear logic into reusable function, added clear button, improved accessibility with aria-hidden, and includes debug console.log to remove |
package.json & package-lock.json |
Updated @ugrc/utah-design-system to v1.33.0 and added @types/terraformer__arcgis type definitions |
.vscode/settings.json |
Added "shapefiles" to spell check dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
steveoh
left a comment
steveoh
left a comment
There was a problem hiding this comment.
looks good. Is it missing dark styles?
Make test page a better reflection of the app page and then fix the AppSearch component layout.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Waiting on agrc/kitchen-sink#567 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Unless you have other ideas, I'm ready to just deal with the strange blank map issue in dev for now.