Add missing return statement in if_not_unset validator#1099
Open
bysiber wants to merge 1 commit intoagronholm:masterfrom
Open
Add missing return statement in if_not_unset validator#1099bysiber wants to merge 1 commit intoagronholm:masterfrom
bysiber wants to merge 1 commit intoagronholm:masterfrom
Conversation
The if_not_unset function defines an inner validate function but never returns it. This means attrs fields using if_not_unset get None as their validator, effectively disabling all validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if_not_unset()defines an innervalidatefunction but never returns it, so all attrs fields using this validator have no validation at all.Problem
The function implicitly returns
None, so attrs treats the field as having no validator. This affectsTaskDefaults.job_executorand allTaskParametersfields — they accept any value without validation.Fix
Add
return validateat the end of the function.