Add the possibility to bind an address on Discovery instead of a device#139
Open
bl0ggy wants to merge 1 commit intoagsh:masterfrom
Open
Add the possibility to bind an address on Discovery instead of a device#139bl0ggy wants to merge 1 commit intoagsh:masterfrom
bl0ggy wants to merge 1 commit intoagsh:masterfrom
Conversation
…ce, in case a device has multiple aliases.
Because of binding and because the urn is set in discovery.js, urn is important so...
Add line 'this.urn = options.urn' removed on a previous commit.
Because of binding, we need to know which alias received the camera, so we now send a remote and local info in Discovery.emit('device').
bl0ggy
changed the title
Collaborator
|
Hi. I cherry picked the bindAddress from this PR today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to bind an address on Discovery instead of a device, in case a device has multiple aliases.
Because of address binding we need to know which alias received the camera, so we now send a remote and a local info in Discovery.emit('device'). This breaks backward compatibility though
The
urnhas been remvoved from theCamconstructor in a previous while it is set in discovery.jsThe
urnis important to compare cameras, so I added it back.