Open
Conversation
added 2 commits
January 18, 2018 18:54
enable focus setting for setImagingSettings function
1 similar comment
chriswiggins
requested changes
Jan 18, 2018
Collaborator
chriswiggins
left a comment
chriswiggins
left a comment
There was a problem hiding this comment.
Hi @mstr-dfeng thanks for your contribution! Can you please do the following for me?
- Remove gotoHomePosition as this is going to be included with #81
- Update the test suite so that the focus command is tested? Add the test in the test/ptz.coffee file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add gotoHomePosition function in ptz.js
enable focus settings of setImagingSettings function in imaging.js