Skip to content

Skip forbidden resources as they are rarely required #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmetb merged 9 commits into from
Nov 23, 2024
Merged

Skip forbidden resources as they are rarely required #55

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6b2166f
Skip forbidden resources as they are rarely required
alam0rt Jul 11, 2022
3a104e4
fix setting error when there's a non-403 error
ahmetb Feb 15, 2023
a56af66
bump to go1.20
ahmetb Feb 15, 2023
f608897
print user-visible warning for forbidden resources
ahmetb Feb 15, 2023
a3cfd3f
use 1.22
alam0rt Oct 22, 2024
739e254
use 1.22 release
alam0rt Oct 22, 2024
fec7227
update go.mod
alam0rt Oct 22, 2024
fcbe860
prefer gomod version
alam0rt Oct 22, 2024
eaca17f
Merge branch 'master' into skip-forbidden-resources
alam0rt Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v1
with:
go-version: 1.18
go-version: 1.20
Copy link
Owner

@ahmetb ahmetb Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to type ' or " around this otherwise it becomes 1.2 float :) at this point let's do 1.22

Copy link
Owner

@ahmetb ahmetb Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg i made this error myself it turns out 🤦

- name: GoReleaser
uses: goreleaser/goreleaser-action@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v1
with:
go-version: 1.18
go-version: 1.20
- name: GoReleaser
uses: goreleaser/goreleaser-action@v1
with:
Expand Down
12 changes: 10 additions & 2 deletions cmd/kubectl-tree/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ package main

import (
"context"
stderrors "errors"
"fmt"
"sync"
"time"

"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/client-go/dynamic"
Expand Down Expand Up @@ -33,8 +35,14 @@ func getAllResources(client dynamic.Interface, apis []apiResource, allNs bool) (
klog.V(4).Infof("[query api] start: %s", a.GroupVersionResource())
v, err := queryAPI(client, a, allNs)
if err != nil {
klog.V(4).Infof("[query api] error querying: %s, error=%v", a.GroupVersionResource(), err)
errResult = err
if errors.IsForbidden(err) {
// should not fail the overall process, but print an info message indicating the permission issue
klog.V(4).Infof("[query api] skipping forbidden resource: %s", a.GroupVersionResource())
klog.Infof("cannot query %s (forbidden), omitting from the tree", a.GroupVersionResource().GroupResource())
} else {
klog.V(4).Infof("[query api] error querying: %s, error=%v", a.GroupVersionResource(), err)
errResult = stderrors.Join(errResult, fmt.Errorf("failed to query the %s resources: %w", a.GroupVersionResource(), err))
}
return
}
mu.Lock()
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/ahmetb/kubectl-tree

go 1.18
go 1.20

require (
github.com/fatih/color v1.13.0
Expand Down