Pass all given props to Flipper component#217
Open
ThenTech wants to merge 1 commit intoaholachek:masterfrom
Open
Pass all given props to Flipper component#217ThenTech wants to merge 1 commit intoaholachek:masterfrom
ThenTech wants to merge 1 commit intoaholachek:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to pass along all other given props of
Flipperto the created element.I'm not sure why this wasn't the case already. My use case is to pass things such as
role,dataandariaattributes to the createddivinstead of having to create yet another nesteddivwith the proper attributes.Note: I don't know if any TypeScript types need to be set, I have never used TS.