Add the ability to override the operating system's reduced motion settings#228
Open
singintime wants to merge 2 commits intoaholachek:masterfrom
Open
Add the ability to override the operating system's reduced motion settings#228singintime wants to merge 2 commits intoaholachek:masterfrom
singintime wants to merge 2 commits intoaholachek:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR provides a setting to override the reduced motion preference of the operating system. This can be useful in case
react-flip-toolkitis used for animations that convey semantic information (e.g. loading spinners), and therefore shouldn't be disabled.Proposed changes
Instead of a boolean flag, the activation toggle now accepts three possible string values: "on", "off", and "system". "On" and "off" enable and disable FLIP animations under any circumstance, respectively. "System" is the default value, and respects the reduced motion preferences set in the operating system.