Skip to content

Conversation

@eWert-Online
Copy link

This implements the suggestion from @tsnobip and @mjambon in #324.

  • The command line can specify multiple tags (-tag producer -tag res)
  • The atd annotations can specify multiple tags (<ocaml tag="producer" tag="foo" name="Foo">)
  • An annotation that doesn't specify a tag is assumed to carry all the tags
    (<ocaml name="Foo"> is selected by -tag bar but <ocaml tag="foo" name="Foo"> is not selected by -tag bar)

The tags are currently implemented by removing all attributes from the AST which do not match the cli argument(s).
This is the easiest way I could think of to implement that feature. If there is a better way or this leads to problems, please let me know 🙂

I am not sure, if the schema changes I made, make sense. I just allowed <... tag="foo"> fields in every attribute location (except for doc attributes).

PR checklist

  • New code has tests to catch future regressions
  • Documentation is up-to-date
  • CHANGES.md is up-to-date

@eWert-Online
Copy link
Author

Hello 👋

Is there anything I can do to get this moving forward?

I still would like to get some feedback on the implementation 🙂

Also I don't know where / how to update the documentation.

@eWert-Online eWert-Online force-pushed the feat/324-annotation-tags branch from f5b4f0d to 907898f Compare October 16, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants