Refresh for pinch-to-zoom for macOS trackpad#1555
Merged
ahrm merged 1 commit intoahrm:developmentfrom Feb 12, 2026
Merged
Conversation
- Separate pinch gesture from TOUCH_MODE so it works with normal mouse behaviour (drag to select, not scroll). TapAndHoldGesture still requires TOUCH_MODE. - Fix render refresh: set no_rerender only during active pinch, reset on gesture end with invalidate_render(). Add validate_render() after each zoom step for live visual feedback. - Zoom towards cursor position instead of page centre, using the existing zoom_in_cursor() which keeps the point under the cursor fixed during zoom.
Owner
|
These should be two different pull requests (and I think the not opening external links makes sense more as a setting and not a command). |
degnbol
force-pushed
the
macos-pinch-zoom
branch
from
cc3e188 to
30950ff
Compare
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
behaviour (drag to select, not scroll). TapAndHoldGesture still
requires TOUCH_MODE.
on gesture end with invalidate_render(). Add validate_render() after
each zoom step for live visual feedback.
existing zoom_in_cursor() which keeps the point under the cursor
fixed during zoom.