Optimize cache key overflow management with performance improvements

[everettbu]

Test 1

[greptile-apps]

Greptile Summary

This PR implements a comprehensive calendar cache optimization system with extensive changes across the Cal.com codebase. The changes fall into several key areas:

Calendar Cache Foundation: The PR introduces a complete calendar cache management system including a new CalendarCacheRepository with methods like getCacheStatusByCredentialIds, database migrations to add updatedAt timestamps to the CalendarCache table, and UI components like CredentialActionsDropdown for cache management. This system enables tracking cache freshness and provides users with visibility into when their calendar data was last updated.

Form Validation & Programmatic Control: Several platform wrapper components (EventTypePlatformWrapper, AvailabilitySettingsPlatformWrapper) have been refactored to use React's forwardRef pattern with useImperativeHandle, exposing validateForm() and handleFormSubmit() methods. This enables parent components to programmatically control form validation and submission, with corresponding TypeScript interfaces (EventTypePlatformWrapperRef, AvailabilitySettingsFormRef) and comprehensive documentation added to the platform atoms.

File Organization & Import Path Standardization: A systematic refactoring standardized naming conventions across the codebase, particularly renaming repository and service files (e.g., eventType.ts → eventTypeRepository.ts, team.ts → teamService.ts) and reorganizing utility functions into lib/ directories. This affects dozens of import statements across the codebase to maintain consistency.

UI/UX Improvements: The booking actions interface was refactored from individual buttons to a dropdown pattern (booking-actions-dropdown), requiring updates to multiple Playwright tests. Several toast components had styling adjustments, and permission-based access controls were added to settings navigation.

Embed System Enhancements: The embed core received significant improvements including new scroll handling utilities (getScrollableAncestor, scrollIntoViewSmooth), Safari-specific iframe scrolling workarounds, and enhanced event handling for scroll-by-distance functionality. These changes address browser compatibility issues, particularly Safari's iframe scrolling limitations.

Database & Service Layer: A new denormalized table system was introduced for routing form responses with extensive trigger functions, and service classes like TeamService were restructured to follow proper service layer patterns with improved error handling and transactional integrity.

The changes integrate well with Cal.com's existing architecture, following established patterns for TRPC routers, React component patterns, and database operations while significantly expanding the calendar cache capabilities and improving overall code organization.

_{94 files reviewed, 19 comments}

_{Edit Code Review Bot Settings | Greptile}

[greptile-apps]

style: Consider using a more specific type than unknown for errors, perhaps string | string[] or the actual form validation error type from your form library

[greptile-apps]

syntax: Typo: 'acccept' should be 'accept'

Suggested change

	it("should set allow='payment' attribute by default to allow Payment Apps to acccept payments", () => {
	it("should set allow='payment' attribute by default to allow Payment Apps to accept payments", () => {

[greptile-apps]

logic: The cache key ["resource-permissions"] is too generic and could lead to cache collisions. Consider including userId, teamId, and resource in the cache key for better cache isolation.

Suggested change

	["resource-permissions"],
	[`resource-permissions-${userId}-${teamId}-${resource}`],

[greptile-apps]

logic: The sed -i '' syntax is macOS-specific and will fail on Linux systems. Consider using a more portable approach or detecting the OS.

Suggested change

	sed -i '' -E "s|^GOOGLE_WEBHOOK_URL=.*|GOOGLE_WEBHOOK_URL=$TUNNEL_URL|" "$ENV_FILE"
	if [[ "$OSTYPE" == "darwin"* ]]; then
	sed -i '' -E "s|^GOOGLE_WEBHOOK_URL=.*|GOOGLE_WEBHOOK_URL=$TUNNEL_URL|" "$ENV_FILE"
	else
	sed -i -E "s|^GOOGLE_WEBHOOK_URL=.*|GOOGLE_WEBHOOK_URL=$TUNNEL_URL|" "$ENV_FILE"
	fi

[greptile-apps]

logic: The permission check logic is nested inside the if (features) block, which means permissions won't be checked if team features are unavailable. This could be a security issue if features and permissions are independent.

[greptile-apps]

logic: The condition e.target === e.currentTarget will only be true if clicking directly on the button element, but the button contains child elements. Users clicking on empty space within the button won't trigger expansion.

[greptile-apps]

style: Redundant logic - these conditions are already checked in getVideoOptionsActions lines 87 and 93

[greptile-apps]

style: The empty object {} as the second parameter suggests this update is purely for triggering updatedAt timestamp changes. Consider adding a comment explaining this intention for future maintainers.

[greptile-apps]

style: The hardcoded 'en-US' locale should use the current user's locale from useLocale() for proper internationalization

[greptile-apps]

style: Multiple subqueries in trigger can cause performance degradation. Consider fetching EventType data in a single query with JOINs.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Optimize cache key overflow management with performance improvements". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit