UX: show complete URL path if website domain is same as instance domain

[everettbu]

Test 6

[greptile-apps]

Greptile Summary

This PR implements a UX improvement to make website URLs in user profiles more contextual and informative. The core change moves website name computation from client-side to server-side logic that intelligently displays either just the hostname (for external domains) or the complete URL path (when the website domain matches or is related to the Discourse instance domain).

The implementation spans several layers:

1. Backend Logic: A new website_name attribute is added to UserSerializer with sophisticated domain comparison logic that handles exact matches, same-level subdomains, and parent-child domain relationships
2. Frontend Cleanup: The client-side websiteName computed property is removed from the user controller, eliminating redundant processing
3. Template Updates: The user profile template now uses model.website_name directly from the serializer instead of the controller's computed property
4. Documentation Fix: A minor JSDoc correction fixes an incorrect property name reference
5. Test Coverage: Comprehensive tests validate the domain matching scenarios

This change is particularly valuable for corporate or organizational Discourse instances where users often link to other pages on the same domain. Instead of showing redundant hostnames like "example.com" when the forum itself is on example.com, users now see the meaningful path information like "example.com/user".

PR Description Notes:

• The PR description "Test 6" is not descriptive and should explain the UX improvement being implemented

Confidence score: 2/5

• This PR has significant implementation issues that could cause runtime errors and incorrect behavior
• The domain comparison logic in UserSerializer#website_name has several problematic areas including unsafe string operations, complex subdomain logic that may fail edge cases, and potential for incorrect domain matching
• Files needing attention: app/serializers/user_serializer.rb (critical domain logic issues), spec/serializers/user_serializer_spec.rb (test coverage gaps)

_{5 files reviewed, 2 comments}

_{Edit Code Review Bot Settings | Greptile}

[greptile-apps]

logic: String concatenation with << modifies the original string. Use + or string interpolation to avoid mutating Discourse.current_hostname

Suggested change

	discourse_host.ends_with?("." << website_host) ? website_host + URI(website.to_s).path : website_host
	discourse_host.ends_with?("." + website_host) ? website_host + URI(website.to_s).path : website_host

[greptile-apps]

style: URI parsing is called twice for the same website URL. Consider storing URI(website.to_s) in a variable for efficiency