Skip to content

Conversation

@everettbu
Copy link

Test 1

* Anonymous: Add device limiter

* break auth if limit reached

* fix typo

* refactored const to make it clearer with expiration

* anon device limit for config

---------

Co-authored-by: Eric Leijonmarck <[email protected]>
@ai-code-review-evaluation ai-code-review-evaluation deleted a comment from cursor bot Jul 26, 2025
@ai-code-review-evaluation ai-code-review-evaluation deleted a comment from cursor bot Jul 27, 2025
@ai-code-review-evaluation ai-code-review-evaluation deleted a comment from cursor bot Jul 28, 2025
@ai-code-review-evaluation ai-code-review-evaluation deleted a comment from cursor bot Jul 28, 2025
@ai-code-review-evaluation ai-code-review-evaluation deleted a comment from cursor bot Jul 28, 2025
@lizard-boy
Copy link

cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 11, 2025
Learn more in the Cursor dashboard.

a.log.Warn("Failed to tag anonymous session", "error", err)
if err := a.anonDeviceService.TagDevice(ctx, httpReqCopy, anonymous.AnonDeviceUI); err != nil {
if errors.Is(err, anonstore.ErrDeviceLimitReached) {
return nil, err
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Anonymous Auth Blocked by Device Limit

Anonymous authentication now fails entirely if anonDeviceService.TagDevice returns ErrDeviceLimitReached. Previously, device tagging was asynchronous and non-blocking. This change prevents anonymous users from authenticating when the device limit is reached.

Locations (1)
Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 28, 2025
@github-actions
Copy link
Contributor

This pull request has been automatically closed because it has not had any further activity in the last 2 weeks. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants