Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2025

Bumps react-mentions and @types/react-mentions. These dependencies needed to be updated together.
Updates react-mentions from 4.1.1 to 4.4.10

Release notes

Sourced from react-mentions's releases.

v4.4.10

Patch Changes

  • c9fd8ca: Remove autofocus from textarea by default
  • 32d9728: Fix suggestions not showing while composing
  • 4ef52dd: Fixed native undo/redo in case the input was not focused before the operation

v4.4.9

Patch Changes

  • 0e26027: Fix double-paste bug

v4.4.8

Patch Changes

  • ad43016: Typing fix in SuggestionsOverlay.js
  • e13731f: Fix package.json properties for release
  • 3f40576: Fixed the suggestions container that was not aligned with the caret position
  • db2d91a: Fix cursor jumping to the end of the textfield when pasting and using React 18
  • 1eef7df: Fix scroll into view automatically
  • a69db87: Custom container scrolling fixed, now works like other containers

v4.4.7

Patch Changes

  • 834240e: SuggestionsOverlay.js refactored to functional component
  • f8e5793: Highlighter.js converted to functional component

v4.4.6

Patch Changes

  • 959625b: Suggestions.js refactored to functional component

v4.4.5

Patch Changes

  • f40cff2: Fix #507 for forceSuggestionsAboveCursor when suggestionsPortalHost is not being used

v4.4.4

Patch Changes

  • 748d38a: fix npm publishing

v4.4.0

4.4.0 (2022-05-27)

Bug Fixes

  • copy & paste from disabled input or textarea (#570) (f275a1e)

... (truncated)

Changelog

Sourced from react-mentions's changelog.

4.4.10

Patch Changes

  • c9fd8ca: Remove autofocus from textarea by default
  • 32d9728: Fix suggestions not showing while composing
  • 4ef52dd: Fixed native undo/redo in case the input was not focused before the operation

4.4.9

Patch Changes

  • 0e26027: Fix double-paste bug

4.4.8

Patch Changes

  • ad43016: Typing fix in SuggestionsOverlay.js
  • e13731f: Fix package.json properties for release
  • 3f40576: Fixed the suggestions container that was not aligned with the caret position
  • db2d91a: Fix cursor jumping to the end of the textfield when pasting and using React 18
  • 1eef7df: Fix scroll into view automatically
  • a69db87: Custom container scrolling fixed, now works like other containers

4.4.7

Patch Changes

  • 834240e: SuggestionsOverlay.js refactored to functional component
  • f8e5793: Highlighter.js converted to functional component

4.4.6

Patch Changes

  • 959625b: Suggestions.js refactored to functional component

4.4.5

Patch Changes

  • f40cff2: Fix #507 for forceSuggestionsAboveCursor when suggestionsPortalHost is not being used

4.4.4

Patch Changes

  • 748d38a: fix npm publishing

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by thomaszi, a new releaser for react-mentions since your current version.


Updates @types/react-mentions from 4.1.0 to 4.4.1

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [react-mentions](https://github.com/signavio/react-mentions) and [@types/react-mentions](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-mentions). These dependencies needed to be updated together.

Updates `react-mentions` from 4.1.1 to 4.4.10
- [Release notes](https://github.com/signavio/react-mentions/releases)
- [Changelog](https://github.com/signavio/react-mentions/blob/master/CHANGELOG.md)
- [Commits](signavio/react-mentions@v4.1.1...v4.4.10)

Updates `@types/react-mentions` from 4.1.0 to 4.4.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-mentions)

---
updated-dependencies:
- dependency-name: react-mentions
  dependency-version: 4.4.10
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: "@types/react-mentions"
  dependency-version: 4.4.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Nov 14, 2025
@akshayutture-augment
Copy link
Contributor

@claude review this PR

@claude
Copy link

claude bot commented Nov 20, 2025

Claude finished @akshayutture-augment's task —— View job


PR Review: Dependency Updates

Reviewing the dependency updates for react-mentions and @types/react-mentions.

Tasks

  • Check for repository guidelines (CLAUDE.md)
  • Examine changed files
  • Search for react-mentions usage in codebase
  • Analyze version changes and changelog
  • Provide review feedback

Review Summary

This PR updates react-mentions from 4.1.1 → 4.4.10 and @types/react-mentions from 4.1.0 → 4.4.1. The changes look good overall and should be safe to merge.

Analysis

Usage in Codebase:
The react-mentions library is used in one primary location:

  • static/app/components/activity/note/input.tsx:2 - For the MentionsInput and Mention components in the note/comment system

Relevant Changes from the Update:

The version jump includes multiple bug fixes that are particularly relevant to this codebase:

Beneficial fixes:

  • Fixed double-paste bug (v4.4.9)
  • Fixed cursor jumping to end when pasting in React 18 (v4.4.8)
  • Fixed native undo/redo functionality (v4.4.10)
  • Fixed suggestions not showing while composing (v4.4.10)
  • Fixed suggestions container alignment with caret position (v4.4.8)
  • Improved scroll-into-view behavior (v4.4.8)

⚠️ Behavioral change to note:

  • Removed default autofocus from textarea (v4.4.10)

Potential Impact:

The autofocus removal in v4.4.10 could affect user experience. Looking at input.tsx:218, the component explicitly sets autoFocus prop:

<MentionsInput
  style={mentionStyle({theme, minHeight})}
 
  onChange={this.handleChange}
  onKeyDown={this.handleKeyDown}
  value={value}
  required
  autoFocus  // ← Explicitly set
>

Since the component explicitly sets autoFocus, this change should not affect the current behavior. The library now requires explicit opt-in rather than being on by default, which is better practice.

Type Safety

The @types/react-mentions update (4.1.0 → 4.4.1) aligns with the library version and should maintain type compatibility. The existing type usage in types.tsx:23 should continue to work correctly:

export type MentionChangeEvent = Parameters<OnChangeHandlerFunc>[0];

Recommendation

✅ APPROVE - This is a safe update that brings multiple bug fixes with no breaking changes. The autofocus behavior change is handled correctly by the existing explicit prop.

Testing Suggestions

While the update looks safe, consider manual testing of:

  1. Comment/note input autofocus behavior
  2. Paste functionality with mentions
  3. Undo/redo operations in the mention input
  4. Mention suggestions display while typing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants