Notification Rule Processing Engine

[akshayutture-augment]

Test 5

---

Replicated from ai-code-review-evaluation/grafana-cursor#5

---

Note

Refactors alerting rule list/menu to rely on Prometheus Grafana rules and new RBAC hooks, removing ruler dependencies and updating tests/utilities.

• Alerting UI:
  • Replace GrafanaRuleLoader with GrafanaRuleListItem and simplify GrafanaGroupLoader to fetch only Prometheus Grafana groups; remove ruler matching logic and loading states.
  • Update AlertRuleMenu and RuleActionsButtons.V2 to compute abilities from both rulerRule and Grafana Prom rule (promRule), enabling actions without ruler calls; construct editable identifiers from promRule.
• RBAC/Abilities:
  • Add Grafana Prom rule ability hooks: useAllGrafanaPromRuleAbilities, useGrafanaPromRuleAbility/Abilities, skipToken; add useIsGrafanaPromRuleEditable and silence/export checks.
  • Extend existing hooks to accept optional rules and return arrays for multiple actions.
• Utils/DTOs:
  • Add isProvisionedPromRule and provenance to GrafanaPromRuleDTO.
  • Remove prefetching ruler groups in Prom groups generator.
• Tests:
  • Update/expand unit tests for rules table, rule details, and Grafana group loader; adjust mocks for new hooks and permissions.
• I18n:
  • Remove unused error strings related to rule detail loading.

^{Written by Cursor Bugbot for commit 3e6d620. Configure here.}

[akshayutture-augment]

cursor review

[cursor]

Bug: Silence Drawer Fails to Render

The silence drawer won't render when rule is undefined (list view scenario with only promRule available), even though the silence button can be shown and clicked based on grafanaPromRuleAbilities. The condition rulerRuleType.grafana.alertingRule(rule) returns false when rule is undefined, preventing the drawer from appearing despite showSilenceDrawer being true.

public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx#L103-L106

cursor-grafana/public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx

Lines 103 to 106 in 3e6d620

	{deleteModal}
	{rulerRuleType.grafana.alertingRule(rule) && showSilenceDrawer && (
	<SilenceGrafanaRuleDrawer rulerRule={rule} onClose={() => setShowSilenceDrawer(false)} />
	)}

 

---

Bug: Cannot Pause Prometheus Rules in Grafana

The pause menu item won't render when rulerRule is undefined (list view scenario), even though canPause can be true based on grafanaPauseAbility. The condition rulerRuleType.grafana.rule(rulerRule) returns false when rulerRule is undefined, preventing users from pausing rules when only promRule is available.

public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx#L116-L119

cursor-grafana/public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx

Lines 116 to 119 in 3e6d620

	const shareUrl = createShareLink(identifier);
	const showDivider =
	[canPause, canSilence, shouldShowDeclareIncidentButton, canDuplicate].some(Boolean) && [canExport].some(Boolean);

 

---

Bug: Conditional Delete Option Not Appearing

The delete menu item won't render when rulerRule is undefined (list view scenario), even though canDelete can be true based on grafanaDeleteAbility. The condition canDelete && rulerRule prevents the delete option from appearing when only promRule is available, and handleDelete requires a non-undefined rulerRule parameter.

public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx#L164-L173

cursor-grafana/public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx

Lines 164 to 173 in 3e6d620

	)}
	{canDelete && rulerRule && (
	<>
	<Menu.Divider />
	<Menu.Item
	label={t('alerting.common.delete', 'Delete')}
	icon="trash-alt"
	destructive
	onClick={() => handleDelete(rulerRule, groupIdentifier)}
	/>

 

---

[cursor]

Bug: Prevent React List Rendering Instability

The GrafanaRuleListItem component is missing the key prop in the list rendering. The key variable is extracted from ruleWithOrigin but not passed to the component, which prevents React from properly tracking list items and can cause rendering issues, lost component state, or performance problems.