Notification Rule Processing Engine #6
Conversation
* wip * Add working actions for GMA rules based on Prom-only API * Remove Ruler-loader related code for Grafana rules Co-authored-by: Sonia Augilar <[email protected]> * Remove outdated tests * add some comments * remove commented code * remove showLocation property * Add missing mocks in tests * Add showLocation to GrafanaRuleListItem, improve useAbilities, address PR feedback * Enhance GrafanaGroupLoader tests: Add permission checks and More button functionality - Introduced user permission grants for alerting actions in tests. - Added tests for rendering the More button with action menu options. - Verified that each rule has its own action buttons and handles permissions correctly. - Ensured the edit button is not rendered when user lacks edit permissions. - Confirmed the correct menu actions are displayed when the More button is clicked. * Update translations --------- Co-authored-by: Sonia Aguilar <[email protected]> Co-authored-by: Sonia Augilar <[email protected]>
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Silence Drawer Fails to Render
The silence drawer won't render when rule is undefined (list view scenario with only promRule available), even though the silence button can be shown and clicked based on grafanaPromRuleAbilities. The condition rulerRuleType.grafana.alertingRule(rule) returns false when rule is undefined, preventing the drawer from appearing despite showSilenceDrawer being true.
public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx#L103-L106
Bug: Cannot Pause Prometheus Rules in Grafana
The pause menu item won't render when rulerRule is undefined (list view scenario), even though canPause can be true based on grafanaPauseAbility. The condition rulerRuleType.grafana.rule(rulerRule) returns false when rulerRule is undefined, preventing users from pausing rules when only promRule is available.
public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx#L116-L119
Bug: Conditional Delete Option Not Appearing
The delete menu item won't render when rulerRule is undefined (list view scenario), even though canDelete can be true based on grafanaDeleteAbility. The condition canDelete && rulerRule prevents the delete option from appearing when only promRule is available, and handleDelete requires a non-undefined rulerRule parameter.
public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx#L164-L173
| rule={rule} | ||
| groupIdentifier={groupIdentifier} | ||
| namespaceName={ruleWithOrigin.namespaceName} | ||
| showLocation={true} |
There was a problem hiding this comment.
Bug: Prevent React List Rendering Instability
The GrafanaRuleListItem component is missing the key prop in the list rendering. The key variable is extracted from ruleWithOrigin but not passed to the component, which prevents React from properly tracking list items and can cause rendering issues, lost component state, or performance problems.
Test 5
Replicated from ai-code-review-evaluation/grafana-cursor#5
Note
Refactors alerting rule list/menu to rely on Prometheus Grafana rules and new RBAC hooks, removing ruler dependencies and updating tests/utilities.
GrafanaRuleLoaderwithGrafanaRuleListItemand simplifyGrafanaGroupLoaderto fetch only Prometheus Grafana groups; remove ruler matching logic and loading states.AlertRuleMenuandRuleActionsButtons.V2to compute abilities from bothrulerRuleand Grafana Prom rule (promRule), enabling actions without ruler calls; construct editable identifiers frompromRule.useAllGrafanaPromRuleAbilities,useGrafanaPromRuleAbility/Abilities,skipToken; adduseIsGrafanaPromRuleEditableand silence/export checks.isProvisionedPromRuleandprovenancetoGrafanaPromRuleDTO.Written by Cursor Bugbot for commit 3e6d620. Configure here.