Plugins: Chore: Renamed instrumentation middleware to metrics middleware #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are (#76186) * Plugins: Chore: Renamed instrumentation middleware to metrics middleware * Removed repeated logger attributes in middleware and contextual logger * renamed loggerParams to logParams * PR review suggestion * Add contextual logger middleware * Removed unused params from logRequest * Removed unwanted changes * Safer FromContext method * Removed traceID from logParams
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 3
Replicated from ai-code-review-evaluation/grafana-cursor#3
Note
Introduce context-aware logging via a new middleware and logger API, rename instrumentation middleware to metrics, and wire the new middlewares into the plugin client stack.
pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.goinjects contextual attributes into requestcontext.InstrumentationMiddleware→MetricsMiddlewarewith same Prometheus metrics; updated constructors/tests and wiring inCreateMiddlewares.logger.FromContext(ctx)and simplifies parameters; removed direct context attribute extraction.pkg/plugins/log: switch variadics to...anyand addLogger.FromContext(context.Context) Logger; implement inlogger.goand test loggerfake.go.Written by Cursor Bugbot for commit 00393c2. Configure here.