GitHub OAuth Security Enhancement #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#67876) We're adding one more step in the GitHub integration installation pipeline, namely GitHub OAuth2 authorize. This is transparent from the UX perspective as the data exchange happens without user interaction. The pipeline will now fail in these cases: - If there is a mismatch between currently authenticated GitHub user (derived from OAuth2 authorize step) and the user who installed the GitHub app (https://github.com/apps/sentry-io) - If there is a mismatch between `state` parameter supplied by user and pipeline signature - If GitHub could not generate correct `access_token` from the `code` (wrong or attempt of re-use of `code`). In all those cases, this error is shown: 
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| pipeline.fetch_state("github_authenticated_user") | ||
| != integration.metadata["sender"]["login"] | ||
| ): | ||
| return error(request, self.active_organization) |
There was a problem hiding this comment.
Bug: Incomplete Metadata Prevents Installation
The code attempts to access integration.metadata["sender"]["login"] without checking if the sender key exists in the metadata. When an integration is created through the normal installation flow without a prior webhook event, the sender metadata won't exist (as seen in build_integration() where it's only added conditionally with if state.get("sender")), causing a KeyError that crashes the installation process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 4
Replicated from ai-code-review-evaluation/sentry-cursor#4
Note
Adds an OAuth login step and validates the authenticated GitHub user matches the installer, with centralized error handling and updated pipeline forwarding.
OAuthLoginViewto pipeline beforeGitHubInstallationto perform GitHub OAuth, exchange code for token, fetch user, and bindgithub_authenticated_user.GitHubInstallation.dispatchto accept/bindinstallation_idfrom pipeline state, enforce single-org install, and verify authenticated user matchesintegration.metadata["sender"]["login"].error()andget_document_origin()helpers for consistent failure responses (invalid request, installed on another org, pending deletion).safe_urlopen,safe_urlread,GitHubIdentityProvider,get_user_info,absolute_uri,reverse).installation_id./userlookup.Written by Cursor Bugbot for commit 843d7c7. Configure here.