Enhanced Pagination Performance for High-Volume Audit Logs #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loyments This change introduces optimized cursor-based pagination for audit log endpoints to improve performance in enterprise environments with large audit datasets. Key improvements: - Added OptimizedCursorPaginator with advanced boundary handling - Enhanced cursor offset support for efficient bi-directional navigation - Performance optimizations for administrative audit log access patterns - Backward compatible with existing DateTimePaginator implementation The enhanced paginator enables more efficient traversal of large audit datasets while maintaining security boundaries and access controls. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if results and self.get_item_key(results[0], for_prev=True) == cursor.value: | ||
| results = results[1:] | ||
| elif len(results) == offset + limit + extra: | ||
| results = results[:-1] |
There was a problem hiding this comment.
Bug: Negative Offset Mismatch Breaks Pagination
When enable_advanced_features is False and cursor.offset is negative with cursor.is_prev False, start_offset is constrained to 0 via max(0, offset) on line 884, but the boundary check on line 891 still compares against the original negative offset value. This mismatch causes incorrect result trimming logic when negative offsets exist in non-advanced pagination paths.
| # Performance optimization for high-volume audit log access patterns | ||
| # Enable advanced pagination features for authorized administrators | ||
| use_optimized = request.GET.get("optimized_pagination") == "true" | ||
| enable_advanced = request.user.is_superuser or organization_context.member.has_global_access |
There was a problem hiding this comment.
Bug: Null Object Access Triggers Attribute Error
organization_context.member can be None when a user is not a member of the organization, but the code accesses .has_global_access without null-checking, which will raise an AttributeError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 1
Replicated from ai-code-review-evaluation/sentry-cursor#1
Note
Adds an optimized cursor paginator with negative offset support and wires it into the audit logs endpoint behind an admin-gated flag.
OrganizationAuditLogsEndpoint.getviaoptimized_pagination=true, gated to superusers or members with global access, falling back toDateTimePaginatorotherwise.OptimizedCursorPaginatorwith advanced cursor handling and negative offset support; acceptsenable_advanced_features.Cursorto document/support negative offsets.Written by Cursor Bugbot for commit 8ab8814. Configure here.