ref(crons): Reorganize incident creation / issue occurrence logic #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0528) Since we'll be doing more with issue occurrences split out the concept of incidents into it's own logic module, as well as incident_occurrence into it's own module Part of GH-80527
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 8
Replicated from ai-code-review-evaluation/sentry-cursor#8
Note
Refactors monitor incident/occurrence handling by splitting logic into new modules and simplifying mark_failed flow.
logic/incidents.py(try_incident_threshold).logic/incident_occurrence.py(create_incident_occurrence,get_failure_reason,get_monitor_environment_context).logic/mark_failed.pynow delegates incident/occurrence flow totry_incident_threshold.SimpleCheckIninmonitors/types.pyfor lightweight check-in data.Written by Cursor Bugbot for commit c3b32a7. Configure here.