FEATURE: automatically downsize large images

[akshayutture-augment]

Test 1

---

Replicated from ai-code-review-evaluation/discourse-greptile#1

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[akshayutture-augment]

@greptileai

[greptile-apps]

Greptile Overview

Confidence Score: 0/5

• This PR contains critical bugs that will break production - duplicate method definitions and incorrect API usage will cause runtime failures
• Score reflects multiple critical logical errors: duplicate method definitions that override existing functionality, incorrect dimension format passed to ImageMagick, potential infinite loops, and frontend/backend validation conflicts. These issues will cause immediate runtime failures.
• All three files require significant rework - optimized_image.rb has duplicate methods breaking existing code, uploads_controller.rb has flawed loop logic and wrong API usage, utilities.js has hardcoded values conflicting with backend

Important Files Changed

File Analysis

Filename	Score	Overview
app/models/optimized_image.rb	0/5	refactored downsize/resize/optimize methods to accept dimensions string, but duplicate method definitions will break existing callers
app/controllers/uploads_controller.rb	1/5	added auto-downsize loop for large images with hardcoded 10MB download limit, but loop doesn't verify size reduction and dimension format is incorrect
app/assets/javascripts/discourse/lib/utilities.js	2/5	hardcoded 10MB max file size replacing dynamic SiteSetting configuration, conflicts with new backend auto-downsize feature

Sequence Diagram

sequenceDiagram
    participant User
    participant Client as utilities.js
    participant Controller as uploads_controller.rb
    participant FileHelper
    participant OptimizedImage
    participant ImageMagick

    User->>Client: Upload large image (e.g. 15MB)
    Client->>Client: Check file.size > 10MB
    alt File > 10MB (hardcoded)
        Client->>User: Show error "file_too_large"
    else File <= 10MB
        Client->>Controller: POST upload
        Controller->>FileHelper: download(url, 10.megabytes)
        FileHelper-->>Controller: tempfile
        Controller->>Controller: Check if image & size > SiteSetting.max_image_size_kb
        alt Needs downsizing
            loop attempt 1-5
                Controller->>OptimizedImage: downsize(path, path, "80%", opts)
                OptimizedImage->>ImageMagick: convert with resize "80%"
                ImageMagick-->>OptimizedImage: Process image
                OptimizedImage-->>Controller: Return
                Controller->>Controller: Check tempfile.size
            end
        end
        Controller->>Controller: Upload.create_for(tempfile)
        Controller-->>User: Upload successful
    end

Loading

[greptile-apps]

Additional Comments (1)

1. app/assets/javascripts/discourse/lib/utilities.js, line 180-186 (link)

   logic: hardcoding 10MB contradicts backend auto-downsize feature - users uploading 15MB images will see client-side error despite backend now handling it

   also removes dynamic SiteSetting configuration flexibility

_{3 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: duplicate method definition - both downsize methods will cause the second to override the first, breaking calls that pass 4 arguments (like in resize_emoji.rb:14)

Suggested change

	def self.downsize(from, to, max_width, max_height, opts={})
	optimize("downsize", from, to, max_width, max_height, opts)
	optimize("downsize", from, to, "#{max_width}x#{max_height}", opts)
	end
	def self.optimize(operation, from, to, width, height, opts={})
	dim = dimensions(width, height)
	def self.downsize(from, to, dimensions, opts={})
	optimize("downsize", from, to, dimensions, opts)
	end
	def self.downsize(from, to, dimensions_or_width, height_or_opts=nil, opts={})
	if height_or_opts.is_a?(Hash)
	# Called with dimensions string: downsize(from, to, "80%", opts)
	optimize("downsize", from, to, dimensions_or_width, height_or_opts)
	else
	# Called with width/height: downsize(from, to, 100, 100, opts)
	optimize("downsize", from, to, "#{dimensions_or_width}x#{height_or_opts}", opts)
	end
	end

Prompt To Fix With AI

This is a comment left during a code review.
Path: app/models/optimized_image.rb
Line: 145:151

Comment:
**logic:** duplicate method definition - both `downsize` methods will cause the second to override the first, breaking calls that pass 4 arguments (like in `resize_emoji.rb:14`)

```suggestion
  def self.downsize(from, to, dimensions_or_width, height_or_opts=nil, opts={})
    if height_or_opts.is_a?(Hash)
      # Called with dimensions string: downsize(from, to, "80%", opts)
      optimize("downsize", from, to, dimensions_or_width, height_or_opts)
    else
      # Called with width/height: downsize(from, to, 100, 100, opts)
      optimize("downsize", from, to, "#{dimensions_or_width}x#{height_or_opts}", opts)
    end
  end
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: loop doesn't check if downsizing actually reduced file size - if OptimizedImage.downsize fails or file is already compressed, this creates infinite loop until attempts exhausted

Prompt To Fix With AI

This is a comment left during a code review.
Path: app/controllers/uploads_controller.rb
Line: 63:70

Comment:
**logic:** loop doesn't check if downsizing actually reduced file size - if `OptimizedImage.downsize` fails or file is already compressed, this creates infinite loop until attempts exhausted

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: passing "80%" as dimensions but downsize method expects either "WIDTHxHEIGHT" format or separate width/height integers - this will likely not work as intended with ImageMagick

Prompt To Fix With AI

This is a comment left during a code review.
Path: app/controllers/uploads_controller.rb
Line: 67:67

Comment:
**logic:** passing "80%" as dimensions but `downsize` method expects either "WIDTHxHEIGHT" format or separate width/height integers - this will likely not work as intended with ImageMagick

How can I resolve this? If you propose a fix, please make it concise.