Notification Rule Processing Engine

[akshayutture-augment]

Test 5

---

Replicated from ai-code-review-evaluation/grafana-greptile#5

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[akshayutture-augment]

@greptileai

[greptile-apps]

Greptile Overview

Confidence Score: 4/5

• This PR is safe to merge with careful monitoring of permissions behavior in production
• The refactoring is well-structured with comprehensive test coverage, but introduces a significant architectural change in how permissions are checked. The dual-source logic (Ruler OR Prometheus) provides good backward compatibility, though the permission checking logic in useIsGrafanaPromRuleEditable needs validation in production to ensure folder permissions work correctly for all scenarios.
• Pay close attention to public/app/features/alerting/unified/hooks/useAbilities.ts - verify that the new useIsGrafanaPromRuleEditable correctly implements permission checks equivalent to the Ruler-based approach

Important Files Changed

File Analysis

Filename	Score	Overview
public/app/features/alerting/unified/hooks/useAbilities.ts	4/5	Added new hooks useGrafanaPromRuleAbility and useGrafanaPromRuleAbilities to check permissions using GrafanaPromRuleDTO instead of RulerRuleDTO, enabling rule list view to work without Ruler API calls. Includes skipToken symbol for conditional hook execution.
public/app/features/alerting/unified/rule-list/GrafanaGroupLoader.tsx	5/5	Removed Ruler API dependency - now only fetches from Prometheus API. Simplified logic by removing rule matching between Ruler and Prometheus responses, eliminating transient state handling for creating/deleting rules.
public/app/features/alerting/unified/rule-list/GrafanaRuleListItem.tsx	5/5	New component that renders a single Grafana rule using only GrafanaPromRuleDTO, replacing GrafanaRuleLoader. Handles alerting, recording, and unknown rule types.
public/app/features/alerting/unified/rule-list/components/RuleActionsButtons.V2.tsx	4/5	Updated to support both RulerRuleDTO and GrafanaPromRuleDTO for ability checks. Uses useGrafanaPromRuleAbility hook to check edit permissions when promRule is available, falling back to useRulerRuleAbility for backward compatibility.
public/app/features/alerting/unified/components/rule-viewer/AlertRuleMenu.tsx	4/5	Refactored to use useRulerRuleAbilities and useGrafanaPromRuleAbilities hooks (plural versions) to batch ability checks. Combines permissions from both Ruler and Prometheus rules using OR logic.

Sequence Diagram

sequenceDiagram
    participant User
    participant RuleListView
    participant GrafanaGroupLoader
    participant PrometheusAPI
    participant RulerAPI
    participant GrafanaRuleListItem
    participant RuleActionsButtons
    participant AlertRuleMenu
    participant useAbilities

    Note over RuleListView,useAbilities: New Flow (Post-PR)
    User->>RuleListView: View alert rules
    RuleListView->>GrafanaGroupLoader: Load group
    GrafanaGroupLoader->>PrometheusAPI: useGetGrafanaGroupsQuery()
    PrometheusAPI-->>GrafanaGroupLoader: GrafanaPromRuleDTO[]
    
    loop For each rule
        GrafanaGroupLoader->>GrafanaRuleListItem: Render rule with promRule only
        GrafanaRuleListItem->>RuleActionsButtons: Pass promRule
        RuleActionsButtons->>useAbilities: useGrafanaPromRuleAbility(promRule)
        useAbilities->>useAbilities: Check folder permissions
        useAbilities-->>RuleActionsButtons: [supported, allowed]
        RuleActionsButtons->>AlertRuleMenu: Pass promRule
        AlertRuleMenu->>useAbilities: useGrafanaPromRuleAbilities(promRule)
        useAbilities-->>AlertRuleMenu: Ability[]
        AlertRuleMenu-->>GrafanaRuleListItem: Menu with permissions
    end

    Note over RuleListView,useAbilities: Old Flow (Pre-PR - REMOVED)
    Note over GrafanaGroupLoader,RulerAPI: Previously called:<br/>useGetGrafanaRulerGroupQuery()<br/>and matched rules

Loading

[greptile-apps]

_{14 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.