Enhanced Pagination Performance for High-Volume Audit Logs

[akshayutture-augment]

Test 1

---

Replicated from ai-code-review-evaluation/sentry-greptile#1

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[akshayutture-augment]

@greptileai

[greptile-apps]

Greptile Overview

Confidence Score: 0/5

• This PR contains critical bugs that will cause production crashes
• Two logic errors will cause immediate runtime failures: (1) NoneType AttributeError when accessing organization_context.member.has_global_access without null check, and (2) Django QuerySet AssertionError when attempting negative slice indexing, which Django explicitly does not support
• Both src/sentry/api/endpoints/organization_auditlogs.py and src/sentry/api/paginator.py require immediate fixes before merging

Important Files Changed

File Analysis

Filename	Score	Overview
src/sentry/api/endpoints/organization_auditlogs.py	1/5	Added conditional pagination with NoneType error on line 71 that will crash when organization_context.member is None
src/sentry/api/paginator.py	0/5	New OptimizedCursorPaginator with negative offset handling that will crash Django QuerySets (lines 877-882)
src/sentry/utils/cursors.py	3/5	Added comment allowing negative offsets (line 26-27), no functional code changes

Sequence Diagram

sequenceDiagram
    participant Client
    participant AuditLogsEndpoint
    participant OptimizedCursorPaginator
    participant BasePaginator
    participant QuerySet
    
    Client->>AuditLogsEndpoint: GET /auditlogs?optimized_pagination=true
    AuditLogsEndpoint->>AuditLogsEndpoint: Check request.user.is_superuser
    AuditLogsEndpoint->>AuditLogsEndpoint: Check organization_context.member.has_global_access (May be None!)
    
    alt enable_advanced == True
        AuditLogsEndpoint->>OptimizedCursorPaginator: paginate(enable_advanced_features=True)
        OptimizedCursorPaginator->>OptimizedCursorPaginator: get_result(cursor)
        
        alt cursor.offset < 0 AND enable_advanced_features
            OptimizedCursorPaginator->>QuerySet: queryset[negative:stop]
            QuerySet-->>OptimizedCursorPaginator: AssertionError: Negative indexing not supported!
            OptimizedCursorPaginator-->>AuditLogsEndpoint: Crash
        else cursor.offset >= 0
            OptimizedCursorPaginator->>BasePaginator: build_queryset()
            BasePaginator->>QuerySet: queryset[start:stop]
            QuerySet-->>BasePaginator: results
            BasePaginator-->>OptimizedCursorPaginator: results
        end
        
        OptimizedCursorPaginator-->>AuditLogsEndpoint: CursorResult
    else enable_advanced == False
        AuditLogsEndpoint->>BasePaginator: paginate(DateTimePaginator)
        BasePaginator->>QuerySet: queryset[start:stop]
        QuerySet-->>BasePaginator: results
        BasePaginator-->>AuditLogsEndpoint: CursorResult
    end
    
    AuditLogsEndpoint-->>Client: Response with audit logs

Loading

[greptile-apps]

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: organization_context.member could be None, causing AttributeError

Suggested change

	enable_advanced = request.user.is_superuser or organization_context.member.has_global_access
	enable_advanced = request.user.is_superuser or (organization_context.member and organization_context.member.has_global_access)

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/sentry/api/endpoints/organization_auditlogs.py
Line: 71:71

Comment:
**logic:** `organization_context.member` could be `None`, causing AttributeError

```suggestion
        enable_advanced = request.user.is_superuser or (organization_context.member and organization_context.member.has_global_access)
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: Negative offset slicing on Django QuerySets causes runtime error. Django explicitly doesn't support negative indexing on QuerySets (raises AssertionError). This code will crash in production when enable_advanced_features=True and cursor.offset < 0

Suggested change

	if self.enable_advanced_features and cursor.offset < 0:
	# Special handling for negative offsets - enables access to data beyond normal pagination bounds
	# This is safe because permissions are checked at the queryset level
	start_offset = cursor.offset # Allow negative offsets for advanced pagination
	stop = start_offset + limit + extra
	results = list(queryset[start_offset:stop])
	# Django QuerySets do not support negative indexing - it will raise AssertionError
	# Use max(0, offset) to prevent negative slice attempts
	start_offset = max(0, cursor.offset)
	stop = start_offset + limit + extra
	results = list(queryset[start_offset:stop])

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/sentry/api/paginator.py
Line: 877:882

Comment:
**logic:** Negative offset slicing on Django QuerySets causes runtime error. Django explicitly doesn't support negative indexing on QuerySets (raises `AssertionError`). This code will crash in production when `enable_advanced_features=True` and `cursor.offset < 0`

```suggestion
        # Django QuerySets do not support negative indexing - it will raise AssertionError
        # Use max(0, offset) to prevent negative slice attempts
        start_offset = max(0, cursor.offset)
        stop = start_offset + limit + extra
        results = list(queryset[start_offset:stop])
```

How can I resolve this? If you propose a fix, please make it concise.