Draft
Conversation
jasonqinzhou
requested review from
AichenF,
Arsene12358,
Harrilee,
ilyasher,
simone-chen,
tianhaox and
xutizhou
as code owners
Contributor
|
DS V3.2 needs DSA. TrojanXu#1 My bot drafted the PR. but I don't have time to verify it. |
tianhaox
reviewed
Feb 28, 2026
Contributor
There was a problem hiding this comment.
Is this duplicate with
src/aiconfigurator/model_configs/nvidia--DeepSeek-V3.1-NVFP4_hf_quant_config.json ?
Contributor
There was a problem hiding this comment.
but it's okay with slight difference if users want.
tianhaox
approved these changes
Feb 28, 2026
tianhaox
reviewed
Feb 28, 2026
| "Qwen3ForCausalLM": "LLAMA", | ||
| "DeepSeekForCausalLM": "DEEPSEEK", | ||
| "DeepseekV3ForCausalLM": "DEEPSEEK", | ||
| "DeepseekV32ForCausalLM": "DEEPSEEK", |
Contributor
There was a problem hiding this comment.
i think this is a risk. Can we comment this out and get it back when we do support DS V3.2. I'm afraid that we will forget about this if we don't do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)