chore: migrate CODEOWNERS from individual usernames to GitHub teams#586
chore: migrate CODEOWNERS from individual usernames to GitHub teams#586jasonqinzhou wants to merge 3 commits intomainfrom
Conversation
….j2 (NVBug 5974038) TRT-LLM requires cache_transceiver_config.backend to be explicitly set for disaggregated serving. The cli_args.j2 template introduced in PR#514 (commit 63d4948) only set max_tokens_in_buffer but omitted the required backend field, causing an AssertionError at runtime on the first request: AssertionError: kv_cache_transceiver is disabled, please set 'cache_transceiver_config: backend:<backend_type>' in config file for disaggregated serving Add 'backend': 'DEFAULT' to the cache_transceiver_config dict, consistent with the pre-regression behavior of all extra_engine_args.*.yaml.j2 templates which always defaulted to backend: DEFAULT. Also add unit tests for cli_args.j2 template rendering to prevent regressions of this class in the future. Made-with: Cursor
Replace long per-line individual username lists with fine-grained @ai-dynamo team references for easier membership management: aic-core — tianhaox, jasonqinzhou, Arsene12358, simone-chen, Harrilee, ilyasher (broad cross-cutting owners) aic-sglang — xutizhou, AichenF aic-vllm — ilyasher, davilu-nvidia aic-systems — YijiaZhao aic-automation — Ethan-ES Devops — anish-shanbhag, ilyasher (already existed) All previous owners are preserved (new entries are strict supersets). Teams aic-core/aic-sglang/aic-vllm/aic-systems/aic-automation need to be created in the ai-dynamo org before merging. Made-with: Cursor
Made-with: Cursor
WalkthroughThe pull request reorganizes repository code ownership from individual contributors to team-based groups, updates a TensorRT-LLM CLI template to include a backend field in cache transceiver configuration, and introduces comprehensive unit tests for the template's argument generation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/CODEOWNERS:
- Line 56: The CODEOWNERS entry for the path "/collector/sglang" still lists the
individual `@davilu-nvidia`; update that line so it uses only team handles (e.g.,
replace `@davilu-nvidia` with the appropriate team like `@ai-dynamo/`<team> or
remove the individual) so ownership is team-based; locate the line with
"/collector/sglang" in the CODEOWNERS file and ensure it lists only team names
(starts with @) consistent with the other entries (`@ai-dynamo/aic-sglang`
`@ai-dynamo/aic-systems` `@ai-dynamo/aic-core`).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 86bff67b-b98d-448a-b911-f967f7e0fd95
📒 Files selected for processing (3)
.github/CODEOWNERSsrc/aiconfigurator/generator/config/backend_templates/trtllm/cli_args.j2tests/unit/generator/test_trtllm_cli_args.py
| /collector/README.md @Arsene12358 @YijiaZhao @tianhaox @jasonqinzhou @simone-chen @Harrilee | ||
| /collector/ @ai-dynamo/aic-core @ai-dynamo/aic-systems | ||
| /collector/deep_collector @ai-dynamo/aic-sglang @ai-dynamo/aic-core | ||
| /collector/sglang @ai-dynamo/aic-sglang @ai-dynamo/aic-systems @ai-dynamo/aic-core @davilu-nvidia |
There was a problem hiding this comment.
Finish the team-only migration on /collector/sglang.
This entry still names @davilu-nvidia directly, so this path is still tied to individual membership churn and no longer matches the team-based ownership goal of this PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/CODEOWNERS at line 56, The CODEOWNERS entry for the path
"/collector/sglang" still lists the individual `@davilu-nvidia`; update that line
so it uses only team handles (e.g., replace `@davilu-nvidia` with the appropriate
team like `@ai-dynamo/`<team> or remove the individual) so ownership is
team-based; locate the line with "/collector/sglang" in the CODEOWNERS file and
ensure it lists only team names (starts with @) consistent with the other
entries (`@ai-dynamo/aic-sglang` `@ai-dynamo/aic-systems` `@ai-dynamo/aic-core`).
Summary
@ai-dynamoteam references throughout CODEOWNERSNew team structure
aic-coreaic-sglangaic-vllmaic-systemsaic-automationDevopscontributors-aiconfiguratorThe 5 new teams must be created in the
ai-dynamoGitHub org first, otherwise team references will resolve to nobody and PRs won't auto-request reviewers:aic-core,aic-sglang,aic-vllm,aic-systems,aic-automationcontributors-aiconfiguratoris (or becomes) a subteam of the org-wide all-NVIDIANs teamWhy
@xutizhou(Xuting ZHOU) was missing from broad coverage — now included viaaic-sglangMade with Cursor
Summary by CodeRabbit
Bug Fixes
Tests