feat: Image decoder in the frontend #3971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesial
changed the title
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
1255231 to
cbe3353
Compare
milesial
requested review from
ayushag-nv,
grahamking,
indrajit96,
krishung5 and
rmccorm4
krishung5
reviewed
Oct 30, 2025
krishung5
approved these changes
Oct 30, 2025
Contributor
krishung5
left a comment
krishung5
left a comment
There was a problem hiding this comment.
Lgtm, one minor comment, thanks.
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
cbe3353 to
5be5da0
Compare
milesial
force-pushed
the
alexandrem/frontend-media-fetching
branch
2 times, most recently
from
8a17e40 to
0f3e79c
Compare
milesial
force-pushed
the
alexandrem/frontend-media-fetching
branch
from
0f3e79c to
3b3593f
Compare
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
5be5da0 to
a9d83fe
Compare
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
4dbec11 to
b888111
Compare
indrajit96
approved these changes
Nov 4, 2025
Contributor
indrajit96
left a comment
indrajit96
left a comment
There was a problem hiding this comment.
Good work! Thanks a lot for this!
LGTM!
grahamking
approved these changes
Nov 4, 2025
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
b888111 to
bed5bd0
Compare
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
b015a61 to
3c4aa12
Compare
rmccorm4
reviewed
Nov 4, 2025
dillon-cullinan
approved these changes
Nov 4, 2025
Contributor
dillon-cullinan
left a comment
dillon-cullinan
left a comment
There was a problem hiding this comment.
Approving the addition of git-lfs into the checkout to allow checkout out a large image being added.
rmccorm4
added
frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
See #3630 for context, this MR is a subset of it, focusing on image decoding, building on top of #3967.
E2E plumbing will be done in a followup MR, the current behavior of URL passthrough stays the default.
Summary by CodeRabbit
New Features
Bug Fixes
Chores