-
Notifications
You must be signed in to change notification settings - Fork 674
ci: OPS-1930: Increase timeout and add max matrix concurrency #4130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dillon Cullinan <[email protected]>
WalkthroughModified GitHub Actions workflow configuration to add concurrency constraints across multiple job matrices and extended pod readiness timeout. The changes introduce max-parallel limits for operator, vLLM, sglang, and trtllm deployment test jobs, plus increased kubectl wait timeout duration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/container-validation-backends.yml(4 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/container-validation-backends.yml
422-422: expecting a single ${{...}} expression or array value for matrix variations, but found plain text node
(syntax-check)
572-572: expecting a single ${{...}} expression or array value for matrix variations, but found plain text node
(syntax-check)
593-593: expecting a single ${{...}} expression or array value for matrix variations, but found plain text node
(syntax-check)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
.github/workflows/container-validation-backends.yml (2)
476-476: Timeout increase appropriately addresses the pod readiness delay risk.The increase from 1000s to 1300s (5-minute buffer) aligns with the PR objective to accommodate long image pulls when multiple pods start simultaneously. This change reduces false timeout failures during heavy concurrent network load on cluster nodes.
40-51: Verify if operator job should also receive max-parallel constraint.The AI summary mentions "operator: max-parallel: 2," but this constraint is not visible in the provided operator job definition (lines 40–51). Confirm whether the operator job's matrix should also be constrained. If added, a
max-parallel: 2would have no effect since the matrix only has 2 platform entries (amd64, arm64), though it would make intent explicit for consistency.
Signed-off-by: Dillon Cullinan <[email protected]>
Signed-off-by: Dillon Cullinan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Overview:
Some attempts to fix occasional pod timeouts in deploy tests. Sometimes the image pulls take a long time. If all tests are triggered on the same time, and get scheduled on the same node, the singular node may get network congested with pulling many large docker images.
Summary:
Summary by CodeRabbit