chore: relax NullStatLogger.record signature

[tzulingk]

Overview:

To be resilient to uninterested upstream signature changes

Details:

Add *args and **kwargs to NullStatLogger.record signature.

Where should the reviewer start?

components/src/dynamo/vllm/publisher.py

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

DIS-984

Summary by CodeRabbit

• Refactor
  • Updated internal logging methods to accept additional arguments, increasing flexibility for future extensibility.

[coderabbitai]

Walkthrough

Two method signatures in the publisher module are extended to accept arbitrary positional and keyword arguments via *args and **kwargs. The record methods in NullStatLogger and DynamoStatLoggerPublisher classes remain functionally identical, with no logic utilizing the additional parameters.

Changes

Cohort / File(s)	Summary
Publisher method signature updates components/src/dynamo/vllm/publisher.py	Extended record method signatures in NullStatLogger and DynamoStatLoggerPublisher classes to accept *args and **kwargs for increased flexibility; return behavior and core logic remain unchanged

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Signature-only changes with no behavioral impact
• Identical pattern applied consistently across two methods
• No functional logic modifications or side effects

Poem

🐰✨ A dash of flexibility, a sprinkle of grace,
These signatures now embrace more arguments in place,
*args and **kwargs open wide the door,
The logic stays steady—unchanged at its core!

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: relaxing the NullStatLogger.record signature to accept additional arguments.
Description check	✅ Passed	The description follows the template structure with all required sections completed: Overview, Details, Where to start, and Related Issues.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 209783d and 744ff58.

📒 Files selected for processing (1)

• components/src/dynamo/vllm/publisher.py (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: tzulingk
Repo: ai-dynamo/dynamo PR: 2666
File: components/backends/trtllm/src/dynamo/trtllm/publisher.py:0-0
Timestamp: 2025-08-25T23:24:42.076Z
Learning: WorkerMetricsPublisher.create_endpoint method signature has been updated in _core.pyi to include metrics_labels parameter: `def create_endpoint(self, component: str, metrics_labels: Optional[List[Tuple[str, str]]] = None)`, making the metrics_labels parameter optional with default value of None.

📚 Learning: 2025-08-25T23:24:42.076Z

Learnt from: tzulingk
Repo: ai-dynamo/dynamo PR: 2666
File: components/backends/trtllm/src/dynamo/trtllm/publisher.py:0-0
Timestamp: 2025-08-25T23:24:42.076Z
Learning: WorkerMetricsPublisher.create_endpoint method signature has been updated in _core.pyi to include metrics_labels parameter: `def create_endpoint(self, component: str, metrics_labels: Optional[List[Tuple[str, str]]] = None)`, making the metrics_labels parameter optional with default value of None.

Applied to files:

• components/src/dynamo/vllm/publisher.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: operator (amd64)
• GitHub Check: vllm (arm64)
• GitHub Check: Build and Test - dynamo

🔇 Additional comments (1)

components/src/dynamo/vllm/publisher.py (1)

24-32: LGTM! Good defensive coding for the null object pattern.

Adding *args and **kwargs to the no-op implementation makes it resilient to upstream vLLM signature changes without any functional impact.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}