chore(kv-router): remove native kv-indexer binary, use maturin-built one [DYN-2459]#7338
chore(kv-router): remove native kv-indexer binary, use maturin-built one [DYN-2459]#7338
Conversation
Signed-off-by: PeaBrane <yanrpei@gmail.com>
WalkthroughRefactors the standalone KV indexer build process from a Rust cargo binary to a Python binding built via maturin. Removes the CLI binary target from the kv-router crate, renames the indexer-bin feature to standalone-indexer, and updates documentation and tests to reflect the new build approach. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/components/router/standalone-indexer.md (1)
84-85: Consider adding a copy-paste test-build command.Small doc polish: include an explicit command using
--features test-endpointsto reduce ambiguity for test setup.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/components/router/standalone-indexer.md` around lines 84 - 85, Add a concrete copy-paste command showing how to install dynamo-kv-indexer into the virtualenv for test builds that need pause/resume listener endpoints: include the package name `dynamo-kv-indexer` and the `--features test-endpoints` flag in the example so users can run it directly (e.g., show the full pip/poetry/installation command variant you use in this repo). Place the command immediately after the existing sentence mentioning `dynamo-kv-indexer` and `--features test-endpoints` so readers have an explicit, ready-to-run example.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/components/router/standalone-indexer.md`:
- Around line 84-85: Add a concrete copy-paste command showing how to install
dynamo-kv-indexer into the virtualenv for test builds that need pause/resume
listener endpoints: include the package name `dynamo-kv-indexer` and the
`--features test-endpoints` flag in the example so users can run it directly
(e.g., show the full pip/poetry/installation command variant you use in this
repo). Place the command immediately after the existing sentence mentioning
`dynamo-kv-indexer` and `--features test-endpoints` so readers have an explicit,
ready-to-run example.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 137a1111-5d02-49bb-96a0-260680679b55
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
docs/components/router/standalone-indexer.mdlib/bindings/python/Cargo.tomllib/kv-router/Cargo.tomllib/kv-router/src/bin/kv_indexer/main.rstests/router/test_router_e2e_with_mockers.py
💤 Files with no reviewable changes (2)
- tests/router/test_router_e2e_with_mockers.py
- lib/kv-router/src/bin/kv_indexer/main.rs
Signed-off-by: PeaBrane <yanrpei@gmail.com>
…er routes Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Remove the duplicate
dynamo-kv-indexerbinary fromlib/kv-routerand consolidate on the maturin-built binary inlib/bindings/python. Addtest-endpointsfeature to the Python bindings Cargo.toml so e2e tests can use the pre-built binary instead ofcargo run.🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Refactoring
Features