Run 34478/gflarity e2e rolling 10 #345
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Changes: - Uncomment Test_RU10_RollingUpdateInsufficientResources to verify delete-first rolling update strategy when nodes are cordoned - Uncomment Test_RU18_RollingUpdateWithPodCliqueScaleOutDuringUpdate to verify rolling updates work correctly with concurrent scale-out Bug Fix (RU18 intermittent failure): - Fix race condition in PodClique status reconciliation where UpdatedReplicas was incorrectly calculated after rolling update completion but before CurrentPodTemplateHash was updated - Add IsLastPCLQUpdateCompleted() helper to detect the window between markRollingUpdateEnd() and mutateCurrentHashes() - Update mutateUpdatedReplica() to use RollingUpdateProgress.PodTemplateHash when the update just completed (UpdateEndedAt is set) - Update mutateCurrentHashes() to properly set CurrentPodTemplateHash and CurrentPodCliqueSetGenerationHash from RollingUpdateProgress Root cause: After markRollingUpdateEnd() set UpdateEndedAt, IsPCLQUpdateInProgress() returned false, causing mutateUpdatedReplica() to use the stale CurrentPodTemplateHash (old hash) instead of the new hash from RollingUpdateProgress. This resulted in UpdatedReplicas=0, which prevented mutateCurrentHashes() from setting CurrentPodCliqueSetGenerationHash, causing the PCS controller to timeout. E2E Setup: - Add Docker authentication support for image pulls from Docker Hub - Skip pulling images that already exist locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: