run e2e only if code changed and build pass #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbar2
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
unmarshall
reviewed
Jan 30, 2026
|
|
||
| # E2E tests - only run after build, check, and test jobs succeed | ||
| # Only triggered by changes to operator or .github folders | ||
| e2e: |
Collaborator
There was a problem hiding this comment.
Does it make sense to allow people to also trigger e2e tests for DRAFT PRs to validate if all tests are running fine before the PR is opened up for review?
If you agree then we can add the following if condition:
e2e:
if: |
(github.event_name == 'pull_request' && (github.event.pull_request.draft == false || contains(github.event.pull_request.labels.*.name, 'run-e2e')))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR optimizes E2E test execution by:
operator/**or.github/**pathstest,build, andcheckjobsThis reduces unnecessary CI resource consumption by skipping expensive E2E tests when:
Which issue(s) this PR fixes:
Fixes #377
Special notes for your reviewer:
.github/workflows/e2e-test.yamland merged its contents intobuild-check-test.yamldorny/paths-filter@v3action to detect path changesneeds: [test, build, check, changes]to enforce orderingDoes this PR introduce a API change?