Merged
Conversation
danbar2
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
danbar2
force-pushed
the
release-ci-automation
branch
from
ce03778 to
dd7194e
Compare
renormalize
reviewed
Feb 11, 2026
Collaborator
renormalize
left a comment
renormalize
left a comment
There was a problem hiding this comment.
Thanks for the PR, a few comments:
Can we move all the changes here to another workflow called .github/workflows/release.yaml. Also:
- The release workflow will be triggered on release events.
- We set up a push artifact job in the release workflow that invokes the
push-artifactsworkflow. - The git tag job will depend on the push artifact job through
needs.
Changes to push-artifacts:
push-artifactsshould not be triggered for release events directly. This workflow will be invoked by the release workflow.
I also think the validation of git tag(s) and OCI artifact tags is unnecessary; if the push fails then the workflow would error anyway. Pulling the docker images will only increase the time taken for the release to succeed.
Having a separate workflow for the release is standard practice, and will make it easier to understand the Actions setup that the repository has.
…cts and git publish
renormalize
reviewed
Feb 11, 2026
Collaborator
renormalize
left a comment
renormalize
left a comment
There was a problem hiding this comment.
Thanks for making all the requested changes! Added a nit, after which we can merge this PR.
Co-authored-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com> Signed-off-by: danbar2 <118804663+danbar2@users.noreply.github.com>
renormalize
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Resolves #404
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: