Auto-MNNVL: Add autoMNNVL e2e tests and cluster setup scripts#421
Open
shmuel-runai wants to merge 6 commits intoai-dynamo:mainfrom
Open
Auto-MNNVL: Add autoMNNVL e2e tests and cluster setup scripts#421shmuel-runai wants to merge 6 commits intoai-dynamo:mainfrom
shmuel-runai wants to merge 6 commits intoai-dynamo:mainfrom
Conversation
Introduce end-to-end tests for the autoMNNVL feature, covering all 4 configurations: - supported + enabled - supported + disabled - unsupported + enabled - unsupported + disabled. Each test suite validates operator behavior (annotation mutation, ComputeDomain lifecycle, resourceClaim injection, annotation immutability) under its specific cluster configuration. Add Python and shell scripts under hack/e2e-autoMNNVL/ to automate k3d cluster creation, fake GPU operator installation, Grove operator deployment, and test execution across all configurations.
Add a dedicated e2e-mnnvl job to the GitHub Actions workflow that runs all 4 autoMNNVL configurations (supported/unsupported x enabled/disabled) in CI, parallel to the existing e2e matrix jobs. The job uses the same trigger conditions and self-hosted runner as the other e2e tests. Add Makefile targets (run-e2e-mnnvl-full, e2e-mnnvl-cluster-down) to invoke the autoMNNVL test orchestration scripts from hack/e2e-autoMNNVL/.
shmuel-runai
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
shmuel-runai
force-pushed
the
RUN-36134/mnnvl-e2e-2
branch
from
833f2da to
066820a
Compare
danbar2
reviewed
Feb 11, 2026
danbar2
reviewed
Feb 11, 2026
danbar2
reviewed
Feb 11, 2026
danbar2
reviewed
Feb 11, 2026
danbar2
reviewed
Feb 11, 2026
shmuel-runai
force-pushed
the
RUN-36134/mnnvl-e2e-2
branch
from
6f84e19 to
8e74f8c
Compare
shmuel-runai
force-pushed
the
RUN-36134/mnnvl-e2e-2
branch
3 times, most recently
from
30b9e3b to
f7bf382
Compare
shmuel-runai
force-pushed
the
RUN-36134/mnnvl-e2e-2
branch
from
f7bf382 to
3c64bd1
Compare
shayasoolin
reviewed
Feb 17, 2026
| Build() | ||
| } | ||
|
|
||
| // deletePCS deletes a PCS by name |
There was a problem hiding this comment.
All of the functions from here till the end of the file are not specific to MNNVL and can be moved to a common testutil file, outside of the auto-mnnvl package.
|
|
||
| // testNoMNNVLArtifactsWhenDisabled verifies that no ComputeDomain is created and no | ||
| // resourceClaims are injected, even for GPU PCS when the feature is disabled. | ||
| func testNoMNNVLArtifactsWhenDisabled(t *testing.T, tc testContext) { |
There was a problem hiding this comment.
What makes this a 'shared' func? I see it only used in 'unsupported and disabled'.
| run_quiet(f"helm uninstall {FAKE_GPU_RELEASE} -n {FAKE_GPU_NAMESPACE}") | ||
| run_quiet("kubectl delete runtimeclass nvidia") | ||
| run_quiet(f"kubectl delete crd {COMPUTE_DOMAIN_CRD}") | ||
| log_success("Fake GPU operator removed") |
There was a problem hiding this comment.
Consider adding code that actually ensures the CRD was removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
refs #270
Special notes for your reviewer:
Does this PR introduce a API change?