[Performance]: Use a cache for PodTemplateHash and optimize calls to CreateOrUpdate#439
Draft
unmarshall wants to merge 5 commits intoai-dynamo:mainfrom
Draft
[Performance]: Use a cache for PodTemplateHash and optimize calls to CreateOrUpdate#439unmarshall wants to merge 5 commits intoai-dynamo:mainfrom
unmarshall wants to merge 5 commits intoai-dynamo:mainfrom
Conversation
* Introduced LRU cache for PodTemplateSpec hashes. * Added utility functions to compute Hash. * Replaced dump.ForHash with JSON marshaling. * Added benchmark tests to different hash computing options to compare. * Adapted Pod component in PCLQ reconciler to use the hash cache. * Adapted PCLQ reconcile status to use the hash cache. * Adapted PCLQ component in PCS reconciler to pre-compute hashes via the hash cache and optimize the calls for CreateOrPatch. * Adapted PCSG status reconciliation to optimize hash computation via hash cache. Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
unmarshall
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee and
shayasoolin
as code owners
Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
/area performance
What this PR does / why we need it:
dump.ForHashand replaced it with simple JSON serialization. Added benchmark tests to prove thatdump.ForHashis quite slow/expensive w.r.t CPU usage.CreateOrUpdatesince that uses too many DeepCopy calls making it a bit expensive.Which issue(s) this PR fixes:
Fixes #406 and partially addresses #407
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: