Closed
Conversation
michal-shalev
requested review from
a team,
brminich,
gleon99 and
yosefe
as code owners
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
michal-shalev
force-pushed
the
add-mapped-ptr-api
branch
6 times, most recently
from
e3ed790 to
1d7c07a
Compare
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
michal-shalev
force-pushed
the
add-mapped-ptr-api
branch
from
f4ea68e to
6fe02ce
Compare
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
rakhmets
reviewed
Dec 18, 2025
Comment on lines
+47
to
+49
| if (status == UCS_ERR_UNREACHABLE) { | ||
| return nullptr; | ||
| } |
Contributor
There was a problem hiding this comment.
Why don't we throw an exception in this case?
getMappedPtrs returns NIXL_SUCCESS, when every rkey::getPtr returns nullptr.
Comment on lines
+1774
to
+1775
| NIXL_ERROR << "getMappedPtrs failed for descriptor " << i << ": " << e.what(); | ||
| return NIXL_ERR_BACKEND; |
Contributor
There was a problem hiding this comment.
I think we don't want to modify std::vector<void *> &ptrs in this case.
| } | ||
|
|
||
| if (status == UCS_ERR_UNREACHABLE) { | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
I think we should just return ptr as ucp_rkey_ptr shouldn't modify it in case of error.
Contributor
Author
|
@brminich @yosefe @ofirfarjun7 @itayalroy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PENDING openucx/ucx#11069 DO NOT MERGE YET
What?
Added
getMappedPtrsAPI to expose UCX's direct access viaucp_rkey_ptr.Why?
This API wraps
ucp_rkey_ptrto expose direct pointer access when supported by the underlying UCX lane.How?
nixlAgent::getMappedPtrs(nixlDlistH*, vector<void*>&)nixl::ucx::rkey::getPtr()wrapper forucp_rkey_ptrnullptrfor lanes without direct access capability