Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/devtools_regression_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,6 @@ jobs:
run: rm -r ./build-regression
- uses: actions/upload-artifact@v4
with:
name: screenshots
path: ./tmp/screenshots
name: playwright-artifacts
path: ./tmp/playwright-artifacts
if-no-files-found: warn
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ packages/react-devtools-inline/dist
packages/react-devtools-shell/dist
packages/react-devtools-timeline/dist

tmp/
3 changes: 3 additions & 0 deletions packages/react-devtools-core/webpack.standalone.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ module.exports = {
test: /\.worker\.js$/,
use: [
{
// NOTE: Keep inline: true for standalone builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
Comment on lines +109 to 112

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment explaining why inline: true is used is not correctly indented, which affects readability. It should be aligned with the loader property within the object for better code style consistency.

Suggested change
// NOTE: Keep inline: true for standalone builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
// NOTE: Keep inline: true for standalone builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',

options: {
inline: true,
Expand Down
6 changes: 2 additions & 4 deletions packages/react-devtools-extensions/src/main/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import registerEventsLogger from './registerEventsLogger';
import getProfilingFlags from './getProfilingFlags';
import debounce from './debounce';
import './requestAnimationFramePolyfill';
import * as ParseHookNames from 'react-devtools-shared/src/hooks/parseHookNames';

function createBridge() {
bridge = new Bridge({
Expand Down Expand Up @@ -189,10 +190,7 @@ function createBridgeAndStore() {
};

// TODO (Webpack 5) Hopefully we can remove this prop after the Webpack 5 migration.
const hookNamesModuleLoaderFunction = () =>
import(
/* webpackChunkName: 'parseHookNames' */ 'react-devtools-shared/src/hooks/parseHookNames'
);
const hookNamesModuleLoaderFunction = () => Promise.resolve(ParseHookNames);

root = createRoot(document.createElement('div'));

Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-extensions/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ module.exports = {
{
loader: 'workerize-loader',
options: {
inline: true,
inline: false,
name: '[name]',
},
},
Expand Down
3 changes: 3 additions & 0 deletions packages/react-devtools-fusebox/webpack.config.frontend.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ module.exports = {
test: /\.worker\.js$/,
use: [
{
// NOTE: Keep inline: true for Fusebox builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
Comment on lines +102 to 105

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment explaining why inline: true is used is not correctly indented, which affects readability. It should be aligned with the loader property within the object for better code style consistency.

Suggested change
// NOTE: Keep inline: true for Fusebox builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
// NOTE: Keep inline: true for Fusebox builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',

options: {
inline: true,
Expand Down
3 changes: 3 additions & 0 deletions packages/react-devtools-inline/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ module.exports = {
test: /\.worker\.js$/,
use: [
{
// NOTE: Keep inline: true for inline builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
Comment on lines +94 to 97

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment explaining why inline: true is used is not correctly indented, which affects readability. It should be aligned with the loader property within the object for better code style consistency.

Suggested change
// NOTE: Keep inline: true for inline builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',
// NOTE: Keep inline: true for inline builds.
// Only extension builds use outlined workers (inline: false)
// because they have a known public path.
loader: 'workerize-loader',

options: {
inline: true,
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/run_devtools_e2e_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const ROOT_PATH = join(__dirname, '..', '..');
const reactVersion = process.argv[2];
const inlinePackagePath = join(ROOT_PATH, 'packages', 'react-devtools-inline');
const shellPackagePath = join(ROOT_PATH, 'packages', 'react-devtools-shell');
const screenshotPath = join(ROOT_PATH, 'tmp', 'screenshots');
const screenshotPath = join(ROOT_PATH, 'tmp', 'playwright-artifacts');

const {SUCCESSFUL_COMPILATION_MESSAGE} = require(
join(shellPackagePath, 'constants.js')
Expand Down
Loading