-
Notifications
You must be signed in to change notification settings - Fork 0
Use outlined workers for DevTools extensions and update CI artifacts #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -99,6 +99,9 @@ module.exports = { | |||||||||||||||||
| test: /\.worker\.js$/, | ||||||||||||||||||
| use: [ | ||||||||||||||||||
| { | ||||||||||||||||||
| // NOTE: Keep inline: true for Fusebox builds. | ||||||||||||||||||
| // Only extension builds use outlined workers (inline: false) | ||||||||||||||||||
| // because they have a known public path. | ||||||||||||||||||
| loader: 'workerize-loader', | ||||||||||||||||||
|
Comment on lines
+102
to
105
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment explaining why
Suggested change
|
||||||||||||||||||
| options: { | ||||||||||||||||||
| inline: true, | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -91,6 +91,9 @@ module.exports = { | |||||||||||||||||
| test: /\.worker\.js$/, | ||||||||||||||||||
| use: [ | ||||||||||||||||||
| { | ||||||||||||||||||
| // NOTE: Keep inline: true for inline builds. | ||||||||||||||||||
| // Only extension builds use outlined workers (inline: false) | ||||||||||||||||||
| // because they have a known public path. | ||||||||||||||||||
| loader: 'workerize-loader', | ||||||||||||||||||
|
Comment on lines
+94
to
97
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment explaining why
Suggested change
|
||||||||||||||||||
| options: { | ||||||||||||||||||
| inline: true, | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment explaining why
inline: trueis used is not correctly indented, which affects readability. It should be aligned with theloaderproperty within the object for better code style consistency.