[Feature] enhance status to ensure consistency#37
Open
DwyaneShi wants to merge 1 commit intoaibrix:devfrom
Open
[Feature] enhance status to ensure consistency#37DwyaneShi wants to merge 1 commit intoaibrix:devfrom
DwyaneShi wants to merge 1 commit intoaibrix:devfrom
Conversation
DwyaneShi
force-pushed
the
haiyang/status-opt
branch
2 times, most recently
from
d12bb04 to
f655ed3
Compare
yapple
reviewed
Mar 17, 2026
| #define PRISKV_DECLARE_STATUS(NAME, CODE, STR, IS_RESP_STATUS) .value("PRISKV_STATUS_" #NAME, PRISKV_CLUSTER_STATUS_##NAME) | ||
| #include "priskv-cluster-status.inc" | ||
| #undef PRISKV_DECLARE_STATUS | ||
| ; |
There was a problem hiding this comment.
+#undef PRISKV_DECLARE_RESP_STATUS_0
+#undef PRISKV_DECLARE_RESP_STATUS_1
+#define PRISKV_DECLARE_RESP_STATUS_1(NAME, CODE) .value("PRISKV_STATUS_" #NAME, PRISKV_CLUSTER_STATUS_##NAME)
+#define PRISKV_DECLARE_RESP_STATUS_0(NAME, CODE)
+#define PRISKV_DECLARE_STATUS(NAME, CODE, STR, IS_RESP_STATUS) PRISKV_DECLARE_RESP_STATUS_##IS_RESP_STATUS(NAME, CODE)
#include "priskv-cluster-status.inc"
+#undef PRISKV_DECLARE_RESP_STATUS_0
+#undef PRISKV_DECLARE_RESP_STATUS_1
should we just export status with IS_RESP_STATUS = 1 ?
Collaborator
Author
There was a problem hiding this comment.
make sense. updated as suggested.
Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
DwyaneShi
force-pushed
the
haiyang/status-opt
branch
from
f655ed3 to
88e4057
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to PrisKV! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to PrisKV's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.