fix: 404 and 401 logging changes

Author: abose

src/auth/auth.js

@@ -17,7 +17,6 @@ function _isBasicAuthPass(request) {
         return false;
     }
     const authHeader = request.headers.authorization;
-    console.log(authHeader);
     if (!authHeader) {
         return false;
     }

src/server.js

@@ -22,7 +22,12 @@ import {HTTP_STATUS_CODES} from "@aicore/libcommonutils";
 import {getConfigs} from "./utils/configs.js";
 import {getHelloSchema, hello} from "./api/hello.js";
 
-const server = fastify({logger: true});
+const server = fastify({
+    logger: true,
+    // https://www.fastify.io/docs/latest/Reference/Server/#trustproxy
+    // needed to forward correct IP addresses in a reverse proxy configuration
+    trustProxy: true
+});
 /* Adding an authentication hook to the server. A hook is a function that is called when a request is made to
 the server. */
 server.addHook('onRequest', (request, reply, done) => {
@@ -33,11 +38,13 @@ server.addHook('onRequest', (request, reply, done) => {
     });
 
     if (!routeExists) {
+        console.error("route does not exist for ", request.raw.url);
         reply.code(HTTP_STATUS_CODES.NOT_FOUND);
-        done(new Error('Not Found'));
+        done('Not Found');
     } else if (!isAuthenticated(request)) {
+        console.error(`Unauthorised access for ${request.raw.url} from IP ${request.ips} `);
         reply.code(HTTP_STATUS_CODES.UNAUTHORIZED);
-        done(new Error('Wrong key'));
+        done("Unauthorized");
     } else {
         done();
     }

test/integration/hello.spec.js

@@ -31,20 +31,15 @@ describe('Integration Tests for hello api', function () {
 
     it('should not say helloAuth if unauthorised', async function () {
         let output = await fetch("http://localhost:5000/helloAuth?name=world", { method: 'GET'});
-        output = await output.json();
-        expect(output).eql({
-            "error": "Unauthorized",
-            "message": "Wrong key",
-            "statusCode": 401});
+        expect(output.status).eql(401);
+        output = await output.text();
+        expect(output).eql("Unauthorized");
     });
 
     it('should reply 404 if route doesnt exist', async function () {
         let output = await fetch("http://localhost:5000/routeNotExist?name=world", { method: 'GET'});
-        output = await output.json();
-        expect(output).eql({
-            "statusCode": 404,
-            "error": "Not Found",
-            "message": "Not Found"
-        });
+        expect(output.status).eql(404);
+        output = await output.text();
+        expect(output).eql("Not Found");
     });
 });