Add custom Introspector class to allow transactions#24
Add custom Introspector class to allow transactions#24samlaycock wants to merge 5 commits intoaidenwallis:mainfrom
Conversation
|
Would this be a breaking change? (Because of the kysely-d1 version bump?) |
|
I can confirm that this PR actually fixes an issue to run migrations with better-auth and Cloudflare D1. I don't think it's a breaking change but actually a fix, the kysely version difference is only in dev dependencies here. Any chance to see this merged and release @aidenwallis ? 🙏 PS: thank you for making this great adapter ❤️ |
|
Sorry @aidenwallis, completely missed your response. Can confirm the version bump isn't a breaking change, it's only to have the correct typescript types. |
|
Hi, this does not allow SQL transactions though, it allows migrations. Is that correct? |
|
Has anyone put together a fork with some of these pull requests included? I had to fork this to an internal lib because the ESM compat pull request was never released to NPM and it was causing the whole CJS release of Kysely to be bundled. I need this pull, the ESM compatibility, the API dialect and the batch helper pull requests. |
|
Any update on this getting merged - I'm also in need of these fixes. |
|
@aidenwallis is there anything preventing this from being merged that we, the community, can help with? |
exampleproject.Description
This dialect used the built-in Kysely
SqliteIntrospectorclass as its introspector, which under the hood makes queries to thesqlite_mastertable, which in D1 is a no go - I've extendedSqliteIntrospectorinto aD1Introspectorto support using thetable_listandtable_infoPRAGMAs to query table metadata instead.Also, I've bumped up the version of
kyselyto the latest while I'm here as there were type discrepancies between0.23.3and0.26.3.