Merged
Conversation
…s the application. Replace PANEL_STYLES with "bg-white" in multiple components to standardize appearance.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Error agent completed without reporting progress |
@react-grab/cli
grab
@react-grab/amp
@react-grab/claude-code
@react-grab/codex
@react-grab/copilot
@react-grab/cursor
@react-grab/droid
@react-grab/gemini
@react-grab/opencode
react-grab
@react-grab/relay
@react-grab/utils
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 24 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/react-grab/src/utils/normalize-error.ts">
<violation number="1" location="packages/react-grab/src/utils/normalize-error.ts:5">
P2: Handle string errors before returning the fallback to avoid swallowing custom string errors.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| error: unknown, | ||
| fallback = "Unknown error", | ||
| ): string => | ||
| error instanceof Error && error.message ? error.message : fallback; |
Contributor
There was a problem hiding this comment.
P2: Handle string errors before returning the fallback to avoid swallowing custom string errors.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/react-grab/src/utils/normalize-error.ts, line 5:
<comment>Handle string errors before returning the fallback to avoid swallowing custom string errors.</comment>
<file context>
@@ -0,0 +1,8 @@
+ error: unknown,
+ fallback = "Unknown error",
+): string =>
+ error instanceof Error && error.message ? error.message : fallback;
+
+export const normalizeError = (error: unknown): Error =>
</file context>
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| const createMentionNode = ( | ||
| displayName: string, | ||
| mentionKey: string, |
Contributor
There was a problem hiding this comment.
Cursor integration broken due to removal of Lexical editor clipboard format support and mention-based plaintext prefix
…ents for enhanced clarity and maintainability. Adjust event handling in context menus and toolbars to streamline user interactions.
Contributor
There was a problem hiding this comment.
1 issue found across 18 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/react-grab/src/utils/register-overlay-dismiss.ts">
<violation number="1" location="packages/react-grab/src/utils/register-overlay-dismiss.ts:36">
P2: Use `event.key === "Enter"` to support both the main Enter key and Numpad Enter.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| return; | ||
| } | ||
|
|
||
| if (event.code === "Enter" && options.onConfirm) { |
Contributor
There was a problem hiding this comment.
P2: Use event.key === "Enter" to support both the main Enter key and Numpad Enter.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/react-grab/src/utils/register-overlay-dismiss.ts, line 36:
<comment>Use `event.key === "Enter"` to support both the main Enter key and Numpad Enter.</comment>
<file context>
@@ -0,0 +1,71 @@
+ return;
+ }
+
+ if (event.code === "Enter" && options.onConfirm) {
+ event.preventDefault();
+ event.stopImmediatePropagation();
</file context>
| error: unknown, | ||
| fallback = "Unknown error", | ||
| ): string => | ||
| error instanceof Error && error.message ? error.message : fallback; |
Contributor
There was a problem hiding this comment.
Suggested change
| error instanceof Error && error.message ? error.message : fallback; | |
| error instanceof Error && error.message | |
| ? error.message | |
| : typeof error === "string" | |
| ? error | |
| : fallback; |
The normalizeErrorMessage function silently discards string errors, returning the fallback message instead of the actual error string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Behavior changes to overlay dismissal/positioning and clipboard writes could affect user interactions and copy integrations, though changes are mostly refactors with added e2e coverage for clipboard metadata.
Overview
Standardizes overlay UI behavior and styling by replacing
PANEL_STYLES/hardcoded z-indexes with explicitbg-whiteandZ_INDEX_LABEL, and by centralizing click-outside/Escape (and optional Enter) handling via newregisterOverlayDismissused across menus/prompts.Simplifies and hardens copy + runtime behavior by removing the Lexical-specific clipboard payload and always writing plain text/HTML plus
application/x-react-grabmetadata (with new e2e coverage that capturesDataTransfer.setDatawrites), and by centralizing error normalization (normalizeError*) plus a few internal refactors (agent session bounds sync moved into agent manager internals, dropdowns re-measure on viewport changes, and cache invalidation renames/cleanups).Written by Cursor Bugbot for commit 93f7132. This will update automatically on new commits. Configure here.
Summary by cubic
Standardized overlay UI and styling, simplified clipboard writes with React Grab metadata, and improved dropdown positioning. Also centralized error handling and fixed a small cookie issue.
Refactors
registerOverlayDismissfor consistent menu/prompt dismissal; dropdowns now re-measure on viewport changes and use a unified offscreen state.PANEL_STYLESwith "bg-white" and standardized z-index with Z_INDEX_LABEL; extractedformatRelativeTimeandLOGO_SVG.normalizeError/normalizeErrorMessage; simplified action enabled checks.application/x-react-grab; added e2e helper to captureDataTransfer.setDataand a test asserting metadata.clearAllCachestoinvalidateInteractionCaches, added OPACITY_CONVERGENCE_THRESHOLD, simplified open-file URL and removedbuild-open-file-url, and trimmed unused props/types.Bug Fixes
Written for commit 93f7132. Summary will update on new commits.