Skip to content

Refactor: Extract modules from core/index.tsx, eliminate silent error swallowing #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidenybai merged 7 commits into from
Mar 19, 2026
Merged

Refactor: Extract modules from core/index.tsx, eliminate silent error swallowing #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
955011f
fix
aidenybai Mar 16, 2026
b258967
Refactor: Update constants and component styles for consistency acros…
aidenybai Mar 16, 2026
350462d
Refactor: Update constants and improve type definitions across compon…
aidenybai Mar 16, 2026
c2f7ddb
Remove primitives section from README docs
aidenybai Mar 17, 2026
b5d3ac6
Refactor: Extract modules from core/index.tsx, eliminate silent error…
aidenybai Mar 18, 2026
e5ab8e1
Revert label-manager/dropdown-controller overabstractions, fix flaky …
aidenybai Mar 19, 2026
3cf2716
Fix duplicate resolveBooleanEnabled declaration from stash merge
aidenybai Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 0 additions & 116 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,122 +193,6 @@ actions: [

See [`packages/react-grab/src/types.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/types.ts) for the full `Plugin`, `PluginHooks`, and `PluginConfig` interfaces.

## Primitives

Use primitives to build your own element selector from scratch. Unlike plugins, primitives are standalone utility functions that don't depend on React Grab being initialized.

If you're using primitives to build a custom UI and don't want the default React Grab overlay, disable auto-initialization before importing `react-grab`:

```html
<script>
window.__REACT_GRAB_DISABLED__ = true;
</script>
```

Here's a simple example of how to build your own element selector with hover highlight and one-click inspection:

```bash
npm install react-grab@latest
```

```tsx
import { useState } from "react";
import {
getElementContext,
freeze,
unfreeze,
openFile,
type ReactGrabElementContext,
} from "react-grab/primitives";

const useElementSelector = (
onSelect: (context: ReactGrabElementContext) => void,
) => {
const [isActive, setIsActive] = useState(false);

const startSelecting = () => {
setIsActive(true);

const highlightOverlay = document.createElement("div");
Object.assign(highlightOverlay.style, {
position: "fixed",
pointerEvents: "none",
zIndex: "999999",
border: "2px solid #3b82f6",
transition: "all 75ms ease-out",
display: "none",
});
document.body.appendChild(highlightOverlay);

const handleMouseMove = ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
if (!target) return;
const { top, left, width, height } = target.getBoundingClientRect();
Object.assign(highlightOverlay.style, {
top: `${top}px`,
left: `${left}px`,
width: `${width}px`,
height: `${height}px`,
display: "block",
});
};

const handleClick = async ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
teardown();
if (!target) return;
freeze();
onSelect(await getElementContext(target));
unfreeze();
};

const teardown = () => {
document.removeEventListener("mousemove", handleMouseMove);
document.removeEventListener("click", handleClick, true);
highlightOverlay.remove();
setIsActive(false);
};

document.addEventListener("mousemove", handleMouseMove);
document.addEventListener("click", handleClick, true);
};

return { isActive, startSelecting };
};

const ElementSelector = () => {
const [context, setContext] = useState<ReactGrabElementContext | null>(null);
const selector = useElementSelector(setContext);

return (
<div>
<button onClick={selector.startSelecting} disabled={selector.isActive}>
{selector.isActive ? "Selecting…" : "Select Element"}
</button>
{context && (
<div>
<p>Component: {context.componentName}</p>
<p>Selector: {context.selector}</p>
<pre>{context.stackString}</pre>
<button
onClick={() => {
const frame = context.stack[0];
if (frame?.fileName) openFile(frame.fileName, frame.lineNumber);
}}
>
Open in Editor
</button>
</div>
)}
</div>
);
};
```

See [`packages/react-grab/src/primitives.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/primitives.ts) for the full `ReactGrabElementContext`, `getElementContext`, `freeze`, `unfreeze`, and `openFile` primitives.

## Resources & Contributing Back

Want to try it out? Check out [our demo](https://react-grab.com).
Expand Down
116 changes: 0 additions & 116 deletions packages/grab/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,122 +193,6 @@ actions: [

See [`packages/react-grab/src/types.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/types.ts) for the full `Plugin`, `PluginHooks`, and `PluginConfig` interfaces.

## Primitives

Use primitives to build your own element selector from scratch. Unlike plugins, primitives are standalone utility functions that don't depend on React Grab being initialized.

If you're using primitives to build a custom UI and don't want the default React Grab overlay, disable auto-initialization before importing `react-grab`:

```html
<script>
window.__REACT_GRAB_DISABLED__ = true;
</script>
```

Here's a simple example of how to build your own element selector with hover highlight and one-click inspection:

```bash
npm install grab@latest
```

```tsx
import { useState } from "react";
import {
getElementContext,
freeze,
unfreeze,
openFile,
type ReactGrabElementContext,
} from "grab/primitives";

const useElementSelector = (
onSelect: (context: ReactGrabElementContext) => void,
) => {
const [isActive, setIsActive] = useState(false);

const startSelecting = () => {
setIsActive(true);

const highlightOverlay = document.createElement("div");
Object.assign(highlightOverlay.style, {
position: "fixed",
pointerEvents: "none",
zIndex: "999999",
border: "2px solid #3b82f6",
transition: "all 75ms ease-out",
display: "none",
});
document.body.appendChild(highlightOverlay);

const handleMouseMove = ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
if (!target) return;
const { top, left, width, height } = target.getBoundingClientRect();
Object.assign(highlightOverlay.style, {
top: `${top}px`,
left: `${left}px`,
width: `${width}px`,
height: `${height}px`,
display: "block",
});
};

const handleClick = async ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
teardown();
if (!target) return;
freeze();
onSelect(await getElementContext(target));
unfreeze();
};

const teardown = () => {
document.removeEventListener("mousemove", handleMouseMove);
document.removeEventListener("click", handleClick, true);
highlightOverlay.remove();
setIsActive(false);
};

document.addEventListener("mousemove", handleMouseMove);
document.addEventListener("click", handleClick, true);
};

return { isActive, startSelecting };
};

const ElementSelector = () => {
const [context, setContext] = useState<ReactGrabElementContext | null>(null);
const selector = useElementSelector(setContext);

return (
<div>
<button onClick={selector.startSelecting} disabled={selector.isActive}>
{selector.isActive ? "Selecting…" : "Select Element"}
</button>
{context && (
<div>
<p>Component: {context.componentName}</p>
<p>Selector: {context.selector}</p>
<pre>{context.stackString}</pre>
<button
onClick={() => {
const frame = context.stack[0];
if (frame?.fileName) openFile(frame.fileName, frame.lineNumber);
}}
>
Open in Editor
</button>
</div>
)}
</div>
);
};
```

See [`packages/react-grab/src/primitives.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/primitives.ts) for the full `ReactGrabElementContext`, `getElementContext`, `freeze`, `unfreeze`, and `openFile` primitives.

## Resources & Contributing Back

Want to try it out? Check out [our demo](https://react-grab.com).
Expand Down
116 changes: 0 additions & 116 deletions packages/react-grab/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,122 +193,6 @@ actions: [

See [`packages/react-grab/src/types.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/types.ts) for the full `Plugin`, `PluginHooks`, and `PluginConfig` interfaces.

## Primitives

Use primitives to build your own element selector from scratch. Unlike plugins, primitives are standalone utility functions that don't depend on React Grab being initialized.

If you're using primitives to build a custom UI and don't want the default React Grab overlay, disable auto-initialization before importing `react-grab`:

```html
<script>
window.__REACT_GRAB_DISABLED__ = true;
</script>
```

Here's a simple example of how to build your own element selector with hover highlight and one-click inspection:

```bash
npm install react-grab@latest
```

```tsx
import { useState } from "react";
import {
getElementContext,
freeze,
unfreeze,
openFile,
type ReactGrabElementContext,
} from "react-grab/primitives";

const useElementSelector = (
onSelect: (context: ReactGrabElementContext) => void,
) => {
const [isActive, setIsActive] = useState(false);

const startSelecting = () => {
setIsActive(true);

const highlightOverlay = document.createElement("div");
Object.assign(highlightOverlay.style, {
position: "fixed",
pointerEvents: "none",
zIndex: "999999",
border: "2px solid #3b82f6",
transition: "all 75ms ease-out",
display: "none",
});
document.body.appendChild(highlightOverlay);

const handleMouseMove = ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
if (!target) return;
const { top, left, width, height } = target.getBoundingClientRect();
Object.assign(highlightOverlay.style, {
top: `${top}px`,
left: `${left}px`,
width: `${width}px`,
height: `${height}px`,
display: "block",
});
};

const handleClick = async ({ clientX, clientY }: MouseEvent) => {
highlightOverlay.style.display = "none";
const target = document.elementFromPoint(clientX, clientY);
teardown();
if (!target) return;
freeze();
onSelect(await getElementContext(target));
unfreeze();
};

const teardown = () => {
document.removeEventListener("mousemove", handleMouseMove);
document.removeEventListener("click", handleClick, true);
highlightOverlay.remove();
setIsActive(false);
};

document.addEventListener("mousemove", handleMouseMove);
document.addEventListener("click", handleClick, true);
};

return { isActive, startSelecting };
};

const ElementSelector = () => {
const [context, setContext] = useState<ReactGrabElementContext | null>(null);
const selector = useElementSelector(setContext);

return (
<div>
<button onClick={selector.startSelecting} disabled={selector.isActive}>
{selector.isActive ? "Selecting…" : "Select Element"}
</button>
{context && (
<div>
<p>Component: {context.componentName}</p>
<p>Selector: {context.selector}</p>
<pre>{context.stackString}</pre>
<button
onClick={() => {
const frame = context.stack[0];
if (frame?.fileName) openFile(frame.fileName, frame.lineNumber);
}}
>
Open in Editor
</button>
</div>
)}
</div>
);
};
```

See [`packages/react-grab/src/primitives.ts`](https://github.com/aidenybai/react-grab/blob/main/packages/react-grab/src/primitives.ts) for the full `ReactGrabElementContext`, `getElementContext`, `freeze`, `unfreeze`, and `openFile` primitives.

## Resources & Contributing Back

Want to try it out? Check out [our demo](https://react-grab.com).
Expand Down
6 changes: 4 additions & 2 deletions packages/react-grab/e2e/edge-cases.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,10 @@ test.describe("Edge Cases", () => {
test.describe("Viewport Edge Cases", () => {
test("should handle elements outside viewport", async ({ reactGrab }) => {
await reactGrab.activate();
await reactGrab.scrollPage(1000);
await reactGrab.page.waitForTimeout(500);

const footer = reactGrab.page.locator("[data-testid='footer']");
await footer.scrollIntoViewIfNeeded();
await reactGrab.page.waitForTimeout(200);

await reactGrab.hoverElement("[data-testid='footer']");
await reactGrab.waitForSelectionBox();
Expand Down
Loading
Loading