Skip to content

[RC 0.1.2] - cleanup, improvements, Re-renders History, Components Tree and more#195

Merged
pivanov merged 14 commits intoaidenybai:mainfrom
pivanov:v1-cleanup-and-improvements
Feb 2, 2025
Merged

[RC 0.1.2] - cleanup, improvements, Re-renders History, Components Tree and more#195
pivanov merged 14 commits intoaidenybai:mainfrom
pivanov:v1-cleanup-and-improvements

Conversation

@pivanov
Copy link
Collaborator

@pivanov pivanov commented Jan 19, 2025

Summary:

  • fix: cleanup + biiome - 0 errors, 0 warnings
  • feat: custom postcss plugin rem2px to prevent target page styles to brake ours
  • feat: Re-renders History
  • Components Tree
    • Search
    • Breadcrumb
    • Resizing + preserve dimentions
  • improve: extension now work with new outlines
  • improve: inspector UI animations and components
  • improve: getOverrideMethods
    • chain updates through all renderers to ensure consistency across different React renderers (e.g., React DOM + React Native Web in the same app)
    • add overrideContext: using overrideProps internally to update the context provider's value prop

@pivanov pivanov requested a review from RobPruzan January 19, 2025 00:12
@vercel
Copy link

vercel bot commented Jan 19, 2025

@pivanov is attempting to deploy a commit to the Million Team on Vercel.

A member of the Team first needs to authorize it.

@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch 2 times, most recently from c2569d8 to 6dc8a17 Compare January 19, 2025 01:27
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 19, 2025

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@195

commit: a06c31e

@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch from 6dc8a17 to feb6137 Compare January 19, 2025 07:26
@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch 2 times, most recently from f52ecbd to 688069d Compare January 22, 2025 03:05
@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch from 688069d to 0217262 Compare January 22, 2025 08:06
@RobPruzan
Copy link
Collaborator

RobPruzan commented Jan 22, 2025

@pivanov would you mind providing a summary of what this PR does in the description?

Both helpful for reviewing so I don't miss anything/makes sure I fully understand context, and is useful for historical records

Something that I think is helpful for large PR's is commenting clarifications on changes themselves in the PR to explain context. For example, some of these helpers are complex but idk their purpose immediately when reviewing, so quickly describing why they exist is very useful

@RobPruzan
Copy link
Collaborator

Here is a video of me using the timeline for the first time, it doesn't seem to work for context/state updates that the component is definitely subscribed to, so the UX will not be good unless the history is consistent

Its also not intuitive for me to use/seems to be some bugs in the state management (watch video). I'm not exactly sure how to use it, or how I'm supposed to use it to optimize/debug the app

And I think we need to make sure this is implemented as an auxiliary feature. The times you will need this is infrequent, so it shouldn't be the first thing you see in the inspector.

This also seems to replace that whats changed view (no longer pops up when state changes). That was well received, so we need to find a way to keep that as is and implement the state update timeline in a different location (note i do notice the what's changed view still exists when you go back in history, but point stands)

Screen-2025-01-22-173240.mp4

@pivanov pivanov changed the title V1 cleanup and improvements [DRAFT] - V1 cleanup and improvements Jan 23, 2025
@pivanov
Copy link
Collaborator Author

pivanov commented Jan 23, 2025

It's not finished yet ... I'm still working on it.
I will let you know when it's ready for testing

@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch 5 times, most recently from 2bf7fca to 55dd792 Compare January 24, 2025 21:28
@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch 3 times, most recently from 6ac52e9 to 3051b88 Compare January 31, 2025 12:17
@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch from 3051b88 to 39537da Compare January 31, 2025 17:08
@pivanov pivanov force-pushed the v1-cleanup-and-improvements branch from 4d4e38d to 60287ff Compare February 2, 2025 01:47
@RobPruzan RobPruzan self-requested a review February 2, 2025 01:54
Copy link
Collaborator

@RobPruzan RobPruzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pivanov pivanov changed the title [V1] - cleanup, improvements, Re-renders History, Components Tree and more [RC 0.1.2] - cleanup, improvements, Re-renders History, Components Tree and more Feb 2, 2025
@pivanov pivanov merged commit f9b462a into aidenybai:main Feb 2, 2025
pivanov added a commit that referenced this pull request Feb 2, 2025
…ee and more (#195)

  fix: cleanup + biiome - 0 errors, 0 warnings
  feat: custom postcss plugin rem2px to prevent target page styles to brake ours
  feat: Re-renders History
  feat: Components Tree
  feat: Search
  feat: Breadcrumb
  feat: Resizing + preserve dimentions
  improve: extension now work with new outlines
  improve: inspector UI animations and components
  improve: getOverrideMethods
  improve: chain updates through all renderers to ensure consistency across different React renderers (e.g., React DOM + React Native Web in the same app)
  improve: overrideContext: using overrideProps internally to update the context provider's value prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants