feat: kitchen sink 2.0 by lxsmnsyc · Pull Request #203 · aidenybai/react-scan

lxsmnsyc · 2025-01-25T10:35:35Z

Provides the barebones kitchen-sink app for react-scan. Just add a new example under kitchen-sink/src/examples
Removed the old examples and kitchen-sink

vercel · 2025-01-25T10:35:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-scan	❌ Failed (Inspect)			Mar 4, 2025 2:41pm

pkg-pr-new · 2025-01-25T10:36:32Z

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@203

commit: 82e5974

lxsmnsyc · 2025-01-25T10:37:44Z

kitchen-sink/src/examples/sierpinski/index.tsx

 import './styles.css';

+
+Store.isInIframe.value = false;


react-scan doesn't work inside iframes, this enables it

lxsmnsyc · 2025-01-25T10:38:28Z

kitchen-sink/src/examples/todo-list/index.tsx

I just copied this from my forgetti example: https://github.com/lxsmnsyc/forgetti/tree/main/examples/react/src

lxsmnsyc · 2025-01-25T10:39:18Z

kitchen-sink/src/main.tsx

+const examples: Example[] = [
+  { title: 'Sierpinski Triangle', url: '/?example=sierpinski' },
+  { title: 'Todo List', url: '/?example=todo-list' },
+];


A little bit manual. When you add a new app in the examples/, this needs to be reflected.

?example query needs to match the folder name

lxsmnsyc · 2025-01-25T10:43:25Z

package.json

  "scripts": {
    "build": "WORKSPACE_BUILD=true node scripts/workspace.mjs build",
    "postbuild": "node scripts/version-warning.mjs",
-    "postinstall": "pnpm build",


A bit annoying.

fyi: pnpm no longer runs this by default, https://github.com/pnpm/pnpm/releases/tag/v10.0.0

there is a small issue with fresh clone ...

🚀 pnpm dev > root@ dev /Users/pivanov/react-scan > node scripts/workspace.mjs dev > react-scan@0.1.3 dev /Users/pivanov/react-scan/packages/scan > pnpm copy-astro && npm-run-all --parallel dev:css dev:tsup > react-scan@0.1.3 copy-astro /Users/pivanov/react-scan/packages/scan > cp -R src/core/monitor/params/astro dist/core/monitor/params cp: dist/core/monitor/params: No such file or directory ELIFECYCLE Command failed with exit code 1. /Users/pivanov/react-scan/packages/scan: ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL react-scan@0.1.3 dev: `pnpm copy-astro && npm-run-all --parallel dev:css dev:tsup` Exit status 1 Scope: 2 of 5 workspace projects packages/extension dev$ pnpm dev:chrome packages/website dev$ next dev --turbopack packages/extension dev: > @react-scan/extension@1.0.4 dev:chrome /Users/pivanov/react-scan/packages/extension packages/extension dev: > cross-env BROWSER=chrome vite packages/website dev: ▲ Next.js 15.0.3 (Turbopack) packages/website dev: - Local: http://localhost:3000 packages/website dev: ✓ Starting... packages/website dev: ✓ Ready in 601ms ....

maybe we should touch a bit ./packages/scan/package.json ... the astro related things?

is this part of the build?

yeah ... I need to check the deps ... because some packages rely on the ./packages/scan/dist we should make sure the scan it's build before the others ... and things like that ... but I will check it when we have more stable file structure

weird, I cannot repro this in my device, perhaps the existence of the dist folder itself. hmmm.

oh ... yeah ... you should remove all dist folders (fresh clone)

pivanov

Nice one!!!

pivanov · 2025-02-04T05:55:23Z

package.json

  "scripts": {
    "build": "WORKSPACE_BUILD=true node scripts/workspace.mjs build",
    "postbuild": "node scripts/version-warning.mjs",
-    "postinstall": "pnpm build",


there is a small issue with fresh clone ...

🚀 pnpm dev > root@ dev /Users/pivanov/react-scan > node scripts/workspace.mjs dev > react-scan@0.1.3 dev /Users/pivanov/react-scan/packages/scan > pnpm copy-astro && npm-run-all --parallel dev:css dev:tsup > react-scan@0.1.3 copy-astro /Users/pivanov/react-scan/packages/scan > cp -R src/core/monitor/params/astro dist/core/monitor/params cp: dist/core/monitor/params: No such file or directory ELIFECYCLE Command failed with exit code 1. /Users/pivanov/react-scan/packages/scan: ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL react-scan@0.1.3 dev: `pnpm copy-astro && npm-run-all --parallel dev:css dev:tsup` Exit status 1 Scope: 2 of 5 workspace projects packages/extension dev$ pnpm dev:chrome packages/website dev$ next dev --turbopack packages/extension dev: > @react-scan/extension@1.0.4 dev:chrome /Users/pivanov/react-scan/packages/extension packages/extension dev: > cross-env BROWSER=chrome vite packages/website dev: ▲ Next.js 15.0.3 (Turbopack) packages/website dev: - Local: http://localhost:3000 packages/website dev: ✓ Starting... packages/website dev: ✓ Ready in 601ms ....

maybe we should touch a bit ./packages/scan/package.json ... the astro related things?

pivanov · 2025-02-04T05:58:23Z

kitchen-sink/src/examples/todo-list/styles.css

+
+.todo-item.pending {
+  background-color: rgba(254, 243, 199, 255);
+}


pivanov · 2025-02-04T05:58:28Z

kitchen-sink/src/index.css

@@ -0,0 +1,3 @@
+body {
+  margin: 0;
+}


pivanov · 2025-02-04T05:58:33Z

kitchen-sink/src/main.css

+
+body {
+  overflow: hidden;
+}


pivanov · 2025-02-04T05:58:44Z

pnpm-workspace.yaml

 packages:
  - 'packages/*'
-  - 'examples/*'
+  - 'kitchen-sink'


lxsmnsyc · 2025-03-05T00:19:48Z

long overdue

lxsmnsyc added 3 commits January 25, 2025 17:31

Remove examples

bb53764

Remove kitchen-sink

6a95fdc

Add kitchen-sink

65d30fa

Update biome.json

9093eba

lxsmnsyc commented Jan 25, 2025

View reviewed changes

vercel bot had a problem deploying to Preview January 25, 2025 10:37 Failure

lxsmnsyc commented Jan 25, 2025

View reviewed changes

Update pnpm-workspace.yaml

2f028d1

vercel bot had a problem deploying to Preview January 25, 2025 10:44 Failure

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

cbe7d37

vercel bot had a problem deploying to Preview February 3, 2025 05:36 Failure

pivanov reviewed Feb 4, 2025

View reviewed changes

fix new lines

499d343

vercel bot had a problem deploying to Preview February 5, 2025 02:14 Failure

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

45fc9df

vercel bot had a problem deploying to Preview February 7, 2025 04:38 Failure

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

a2a1abd

vercel bot had a problem deploying to Preview February 10, 2025 10:47 Failure

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

82544c1

vercel bot had a problem deploying to Preview February 13, 2025 03:01 Failure

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

4f499b6

vercel bot had a problem deploying to Preview February 17, 2025 04:19 Failure

lxsmnsyc added 2 commits March 4, 2025 22:40

Merge remote-tracking branch 'origin/main' into kitchen-sink-cleanup

0580f28

Update pnpm-lock.yaml

82e5974

vercel bot had a problem deploying to Preview March 4, 2025 14:41 Failure

lxsmnsyc merged commit 920f2c3 into main Mar 5, 2025
4 of 5 checks passed

lxsmnsyc deleted the kitchen-sink-cleanup branch March 5, 2025 00:19

@@ @@ -0,0 +1,3 @@ @@
+              body {
+                margin: 0;
+              }

                
                    No newline at end of file

Conversation

lxsmnsyc commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pivanov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lxsmnsyc commented Mar 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lxsmnsyc commented Jan 25, 2025 •

edited

Loading

vercel bot commented Jan 25, 2025 •

edited

Loading

pkg-pr-new bot commented Jan 25, 2025 •

edited

Loading