fix: compatible with styled components#376
Merged
RobPruzan merged 1 commit intoaidenybai:mainfrom May 13, 2025
Merged
Conversation
|
@tengweiherr is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Collaborator
|
LGTM, nice work 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #355
@emotion/styledandstyled-componentscall components with forwardRef when generating them. We weren’t retrieving the fiber type from ForwardRef correctly, as it has a different data structure compared to functional and host componentsTo fix it, we just need to make a one line change: use
getRenderData(getType(node?.fiber))instead ofgetRenderData(node?.fiber.type).Also, I cleaned up the code a bit as I just found out that Bippy already provides getFiberId to manage uniqueId for fibers, so we don't really need to implement our own fiber identifier.
Tested on the preview link https://wys52t.csb.app mentioned in #355
demo.mov