Skip to content

Conversation

@agoscinski
Copy link
Contributor

@agoscinski agoscinski commented May 9, 2025

In addition to the current state on main b618cb7 I included for production testing the PRs

Please test again with this prerelease:

  • ssh_async did not work last time
  • verdi process kill could bypass EBM by sequentially killing
  • dumping of the profile returned an error

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

❌ Patch coverage is 62.34133% with 1068 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.47%. Comparing base (b618cb7) to head (e4205e9).
⚠️ Report is 7 commits behind head on support/2.7.0pre1.

Files with missing lines Patch % Lines
src/aiida/tools/dumping/managers/profile.py 55.50% 178 Missing ⚠️
src/aiida/tools/dumping/logger.py 60.90% 122 Missing ⚠️
src/aiida/tools/dumping/managers/process.py 72.75% 109 Missing ⚠️
src/aiida/tools/dumping/detect.py 75.13% 96 Missing ⚠️
src/aiida/tools/dumping/utils/paths.py 58.13% 85 Missing ⚠️
src/aiida/tools/dumping/config.py 60.58% 82 Missing ⚠️
src/aiida/tools/dumping/facades.py 40.00% 78 Missing ⚠️
src/aiida/cmdline/commands/cmd_profile.py 36.96% 58 Missing ⚠️
src/aiida/tools/dumping/utils/helpers.py 63.30% 58 Missing ⚠️
src/aiida/cmdline/commands/cmd_group.py 34.22% 50 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                  Coverage Diff                  @@
##           support/2.7.0pre1    #6872      +/-   ##
=====================================================
- Coverage              78.59%   77.47%   -1.12%     
=====================================================
  Files                    567      576       +9     
  Lines                  43092    45707    +2615     
=====================================================
+ Hits                   33866    35409    +1543     
- Misses                  9226    10298    +1072     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

)
__license__ = 'MIT license, see LICENSE.txt file.'
__version__ = '2.6.3.post0'
__version__ = '2.7.0pre1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be?

Suggested change
__version__ = '2.7.0pre1'
__version__ = '2.7.0rc1'

Copy link
Contributor Author

@agoscinski agoscinski May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So PEP does not anymore support pre (In old it still was). When released it is automatically converted to rc0 last time but I started this usage preX so I thought for these preleases I just stay consistent and use preX. No strong feelings about either way.

Copy link
Collaborator

@danielhollas danielhollas May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is very confusing to have a version of pypi different from __version__.

Copy link
Contributor Author

@agoscinski agoscinski May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it is also confusing to have a history (on git) of

2.7.0pre0
2.7.0rc1

so what do you prefer? Next time I want to start with rc0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well hopefully not many people are installing these versions so ultimately it doesn't matter I guess. :-) no strong opinions, with preference to switch to rc1 now.

agoscinski and others added 2 commits May 9, 2025 22:07
Squashed commit at 2025-05-09 21:53

PR aiidateam#6793 introduced the cancelation of earlier kill actions. This had
the problem if two kill commands are set in a sequence, the second kill
action will cancel the first one which triggered the cancelation of the
scheduler job within an EBM. The second kill command however did not
retrigger the cancelation of the scheduler job. This bug appeared
because we have two places where the killing logic is placed. More
information about this can be found in PR aiidateam#6868 that fixes this properly
refactoring the kill action. This PR only serves as a fast temporary fix
with workarounds.

Before this PR, when the killing command failed through the EBM, the
scheduler job could not be cancelled through a kill anymore. Since we
have now force-kill option to bypass the EBM, we can reschedule the
cancelation of the scheduler job to gracefully kill a process.
Squashed commit at 2025-05-09 21:54

Add config pydantic model

Add detect.py

Add group-node-mapping

Add dump logger

Add dump engine

Add dump managers

Add facades

Add utils

Add changes to CLI

Add changes to init, disable mypy for feature for now

Add changes to docs

Add changes to and additional tests

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fix bug in explicitly-groupd sub-workflows being filtered out for profile/group dumping

Fix group validation exception on `verdi profile dump -G` and creation of empty dirs for deselected groups.
@agoscinski agoscinski force-pushed the support/2.7.0pre1 branch from 8055b5d to 3b96a2f Compare May 9, 2025 20:07
danielhollas and others added 3 commits May 9, 2025 22:11
…iidateam#6867)

Squashed commit at 2025-05-09 22:04

defer_build in Entity.Model class

defer_build in Entity.Model pydantic class
Cherry-picked at 2025-05-09 22:06

This aims to avoid reconstruction of fields from parent models during MRO walks.
@agoscinski agoscinski force-pushed the support/2.7.0pre1 branch from 3b96a2f to e4205e9 Compare May 9, 2025 20:11
@agoscinski agoscinski marked this pull request as ready for review May 9, 2025 20:42
@agoscinski agoscinski merged commit b313269 into aiidateam:support/2.7.0pre1 May 9, 2025
9 of 12 checks passed
@agoscinski agoscinski deleted the support/2.7.0pre1 branch May 9, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants