Additional logging during dump operations
#7046
Open
+85
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeigerJ2
force-pushed
the
dump-logging-when-time-intensive
branch
from
40e616e to
b876283
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
==========================================
- Coverage 79.29% 79.28% -0.00%
==========================================
Files 566 566
Lines 43847 43847
==========================================
- Hits 34763 34761 -2
- Misses 9084 9086 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GeigerJ2
changed the title
dump operations
|
@agoscinski, nice, i'm running into sql errors when running dump with the testing group 🥲 |
agoscinski
approved these changes
Oct 6, 2025
GeigerJ2
force-pushed
the
dump-logging-when-time-intensive
branch
from
a00fa52 to
6d5469c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For (possibly) time-intensive preparatory tasks during the dumping (querying from db, filtering based on certain criteria such as previously being dumped, or exclusion based on filters, etc.), additional logging is added before and after the operation, while the operations themselves are wrapped in progress bars, where applicable. This makes the output when running the command much more user-friendly, as it doesn't seem like the code is just stuck during a more time-intensive operation, but the display remains responsive and shows what's going on internally.
This is not a fix to #6913, per se, in the same way that what was reported in #6913 was not an actual bug. Possible speed improvements of the dumping-related code are a possible consideration for v2.8.0. For the a v2.7.2 patch release, I deem the additional logging in this PR to be sufficient.