Updates inheritance: from BashCliScheduler instead of Scheduler
#43
Conversation
khsrali
force-pushed
the
inherit-from-BashCliScheduler
branch
from
ec52678 to
d601194
Compare
superstar54
left a comment
superstar54
left a comment
There was a problem hiding this comment.
Hi @khsrali , thanks for the fix! See my comment below.
pyproject.toml
Outdated
|
|
||
| dependencies = [ | ||
| "aiida-core~=2.0", | ||
| "aiida-core>=2.7", |
There was a problem hiding this comment.
Better add upper bound.
| "aiida-core>=2.7", | |
| "aiida-core>=2.7, <3", |
There was a problem hiding this comment.
Won't aiida-core~=2.7 also do the trick?
There was a problem hiding this comment.
aiida-core~=2.7 will not upgrade aiida-core if the users already have aiida-core 2.6 in the environment. Thus, they need to upgrade aiida-core manually.
There was a problem hiding this comment.
Are you sure? The following should be equivalent according to the documentation:
~= 2.2
>= 2.2, == 2.*
There was a problem hiding this comment.
You are right! I tested it locally, and it indeed upgraded aiida-core to 2.7.1, and yes, the doc shows very clearly that ~= 2.2 is equivalent to >= 2.2, == 2.*.
|
Thanks @superstar54 review applied, please approve |
aiidalab/aiidalab-qe#1316
RTD is failing, which is independent of this PR