-
Notifications
You must be signed in to change notification settings - Fork 7
Replace the dict-based way of declaring sockets and namespaces with the spec API #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
aed3780
758b9eb
b9d6ac7
f2a146c
8d7d792
2566cd8
e445828
84d9853
19b33f7
0f8a18e
06d03e2
a89a8a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ def __init__(self, *args, **kwargs) -> None: | |
| def func(self) -> t.Callable[..., t.Any]: | ||
| import cloudpickle | ||
|
|
||
| if self._func is None: | ||
| if not getattr(self, "_func", None): | ||
|
||
| self._func = cloudpickle.loads(self.inputs.function_data.pickled_function) | ||
| return self._func | ||
|
|
||
|
|
@@ -189,7 +189,8 @@ def parse(self, results): | |
| if exit_code: | ||
| return exit_code | ||
| # Store the outputs | ||
| for output in self.output_ports["ports"]: | ||
| self.out(output["name"], output["value"]) | ||
| for name, port in self.output_ports["ports"].items(): | ||
| if "value" in port: | ||
| self.out(name, port["value"]) | ||
|
|
||
| return ExitCode() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for future reference, it only needs to be as long as the title (less raises an issue, more is unnecessary) 🙂