Skip to content

Fix typo in pythonjob.numpy.ndarray entrypoint#54

Merged
edan-bainglass merged 1 commit intomainfrom
fix-ndarray-entry-point
Sep 28, 2025
Merged

Fix typo in pythonjob.numpy.ndarray entrypoint#54
edan-bainglass merged 1 commit intomainfrom
fix-ndarray-entry-point

Conversation

@edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Sep 27, 2025

Typo at the end of the reference corrected from .ArrayData to :ArrayData

I found this while trying to dynamically generate Models for FastAPI. The pythonjob.numpy.ndarray endpoint wouldn't load. Found the typo. I guess there are no tests to check this here? Maybe good to add tests to verify that all entry points are loadable 🙂


Incidentally, I made a typo in the commit message 😅

Typo at the end of the reference corrected from `.ArrayData` to `:ArrayData`
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (7433dcd) to head (e7e822c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          22       22           
  Lines        1232     1232           
=======================================
  Hits         1115     1115           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edan-bainglass edan-bainglass changed the title Fix typo in pythonjob,numpy.ndarray entrypoint Fix typo in pythonjob.numpy.ndarray entrypoint Sep 27, 2025
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edan-bainglass edan-bainglass merged commit d289ac5 into main Sep 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants