Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 89.87% 89.42% -0.46%
==========================================
Files 22 22
Lines 1324 1324
==========================================
- Hits 1190 1184 -6
- Misses 134 140 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agoscinski
force-pushed
the
aiida-core-v2.8.0-support
branch
2 times, most recently
from
374b9fb to
c83d5eb
Compare
The fix in 86f21bd only considered 2.8.0 and above, for any alpha, beta or pre-release the workaround was not correctly disabled.
agoscinski
force-pushed
the
aiida-core-v2.8.0-support
branch
from
f5fbcdb to
53eaf70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to actually not remove here but make its usage dependent on aiida-core version, since it is still needed for older versions.